Sign upLogin

BelirafoN/asterisk-ami-client

View on GitHub
Star

Showing 7 of 7 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        client
            .on('connect', () => console.log('connect'))
            .on('event', event => console.log(event))
            .on('data', chunk => console.log(chunk))
            .on('response', response => console.log(response))
Severity: Major
Found in examples/availableEvents.js and 1 other location - About 6 hrs to fix
examples/withCo/availableEvents.js on lines 17..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    client
        .on('connect', () => console.log('connect'))
        .on('event', event => console.log(event))
        .on('data', chunk => console.log(chunk))
        .on('response', response => console.log(response))
Severity: Major
Found in examples/withCo/availableEvents.js and 1 other location - About 6 hrs to fix
examples/availableEvents.js on lines 15..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function connect has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    connect(user, secret, options){
        this._credentials = {user, secret};
        this._connectionOptions = options || {};

        return this._connector.connect(user, secret, options)
Severity: Major
Found in lib/AmiClient.js - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            client
            .on('event', event => console.log(event))
            .on('response', response => {
                console.log(response);
                client.disconnect();
    Severity: Major
    Found in examples/baseUsage.js and 1 other location - About 2 hrs to fix
    examples/withCo/baseUsage.js on lines 21..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        client
        .on('event', event => console.log(event))
        .on('response', response => {
            console.log(response);
            client.disconnect();
    Severity: Major
    Found in examples/withCo/baseUsage.js and 1 other location - About 2 hrs to fix
    examples/baseUsage.js on lines 19..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File AmiClient.js has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Developer: BelirafoN
 * Date: 27.04.2016
 * Time: 15:37
 */
    Severity: Minor
    Found in lib/AmiClient.js - About 2 hrs to fix

      Function constructor has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          constructor(options){
        super();

        Object.assign(this, {
            _specPrefix: '--spec_',
      Severity: Minor
      Found in lib/AmiClient.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language