Sign upLogin

BenLubar/dfhackrpc

View on GitHub
Star

Showing 6 of 7 total issues

Function writeImports has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
Open

func writeImports(w io.Writer, decls [][3]string, pluginMessages []string) {
    if len(decls) == 0 {
        return
    }
Severity: Minor
Found in dfproto/mkwrappers.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function writeWrapper has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func writeWrapper(w io.Writer, plugin, method, input, output, packageName string, pluginMessages []string) {
    fmt.Fprintf(w, "\n// Call%s is a convenience wrapper around the %s RPC method.\n", method, qualifiedName(plugin, method))

    var inputDecl, outputDecl string
    if uw, ok := unwrap[[2]string{getPrefix2(input, packageName, pluginMessages), input}]; ok {
Severity: Minor
Found in dfproto/mkwrappers.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build ignore
Severity: Minor
Found in dfproto/mkwrappers.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Command dfhack-run is a port of the dfhack-run command in C++ to Go.
Severity: Minor
Found in cmd/dfhack-run/main.go by gofmt

don't use an underscore in package name
Open

package dfproto_core
Severity: Minor
Found in dfproto/core/doc.go by golint

2: cannot find package "github.com/mattn/go-colorable" in any of:
Open

    "github.com/mattn/go-colorable"
Severity: Minor
Found in client.go by govet
Severity
Category
Status
Source
Language