Sign upLogin

BenMusch/nu-tab

View on GitHub
Star
app/models/round.rb

Summary

Maintainability
A
1 hr
Test Coverage

Showing 2 of 2 total issues

Method validate_standard_result has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_standard_result
    if all_stats_submitted?
      errors.add(:base, 'Ranks are invalid')             unless valid_ranks?
      errors.add(:base, 'Speaks are invalid')            unless valid_speaks?
      errors.add(:base, 'Speaks/Ranks are out of order') unless valid_speaks_ranks_order?
Severity: Minor
Found in app/models/round.rb - About 1 hr to fix

Use %i or %I for an array of symbols.
Open

  enum result: [:gov_win, :opp_win, :gov_forfeit, :opp_forfeit, :all_drop, :all_win]
Severity: Minor
Found in app/models/round.rb by rubocop
Category
Status