Sign upLogin

Bernd-L/exDateMan

View on GitHub
Star
backend/src/app/authentication.ts

Summary

Maintainability
D
2 days
Test Coverage

File authentication.ts has 271 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Router, Request, Response } from "express";
import { readFileSync } from "fs";
import * as jwt from "jsonwebtoken";
import { ServerEvents, UserEvent } from "./server-events";
import { compareSync, hashSync } from "bcrypt";
Severity: Minor
Found in backend/src/app/authentication.ts - About 2 hrs to fix

    Function handleLogin has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private async handleLogin(req: Request, res: Response) {
    try {
      /**
       * The saltedPwdHash from the users projection
       */
    Severity: Minor
    Found in backend/src/app/authentication.ts - About 1 hr to fix

      Function handleRegister has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private async handleRegister(req: Request, res: Response) {
    // Check for duplicate email
    if (
      Authentication.usersProjection.find((user: User) => {
        return user.email === req.body.email;
      Severity: Minor
      Found in backend/src/app/authentication.ts - About 1 hr to fix

        Function updateUsersProjection has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public static updateUsersProjection(event: UserEvent) {
    const index = Authentication.usersProjection.findIndex(
      (user: User) => user.uuid === event.data.userUuid,
    );
        Severity: Minor
        Found in backend/src/app/authentication.ts - About 1 hr to fix

          Function updateUsersProjection has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            public static updateUsersProjection(event: UserEvent) {
    const index = Authentication.usersProjection.findIndex(
      (user: User) => user.uuid === event.data.userUuid,
    );
          Severity: Minor
          Found in backend/src/app/authentication.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            private handleResolveEmail(req: Request, res: Response): void {
    /**
     * This constant holds the copy of the found value
     */
    const result: User | undefined =
          Severity: Major
          Found in backend/src/app/authentication.ts and 1 other location - About 6 hrs to fix
          backend/src/app/authentication.ts on lines 106..132

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 174.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            private handleGetUser(req: Request, res: Response): void {
    /**
     * This constant holds the copy of the found value
     */
    const result: User | undefined =
          Severity: Major
          Found in backend/src/app/authentication.ts and 1 other location - About 6 hrs to fix
          backend/src/app/authentication.ts on lines 75..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 174.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status