Sign upLogin

Bernd-L/exDateMan

View on GitHub
Star
frontend/src/app/services/stock/stock.service.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function fetchAllInventoryThingStocks has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  private async fetchAllInventoryThingStocks() {
    console.log("fetch all Stocks");

    // Wait for the other services to be ready
    await this.ts.ready;
Severity: Minor
Found in frontend/src/app/services/stock/stock.service.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function applyStockEvent has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private async applyStockEvent(stockEvent: Event) {
    await this.is.ready;

    /**
     * One date representing now
Severity: Minor
Found in frontend/src/app/services/stock/stock.service.ts - About 1 hr to fix

    Function updateStock has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async updateStock(
    stock: Stock,
    inventoryUuid: string,
    thingUuid: string
  ): Promise<void> {
    Severity: Minor
    Found in frontend/src/app/services/stock/stock.service.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          for (const inventoryEvents of EventSourcingService.events) {
      // Iterate over the Events of the Inventory
      for (const event of inventoryEvents.events) {
        // But only if when the Event is a StockEvent
        if (event.data.itemType === itemType.STOCK) {
      Severity: Major
      Found in frontend/src/app/services/stock/stock.service.ts and 1 other location - About 2 hrs to fix
      frontend/src/app/services/category/category.service.ts on lines 83..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status