Sign upLogin

BetterTyped/hyper-fetch

View on GitHub
Star
packages/adapter-firebase-admin/src/adapter/adapter.ts

Summary

Maintainability
C
1 day
Test Coverage

Function firebaseAdminAdapter has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  () => {
    const adapter: FirebaseAdminAdapterTypes<T> = async (request, requestId) => {
      const { fullUrl, onSuccess, onError, onRequestStart, onResponseEnd, onResponseStart, onRequestEnd } =
        await getAdapterBindings<RealtimeDbAdapterType | FirestoreAdapterType>(request, requestId, "error", {});
      return new Promise<ResponseReturnType<any, any, FirebaseAdminAdapterTypes<T>>>((resolve) => {
Severity: Minor
Found in packages/adapter-firebase-admin/src/adapter/adapter.ts - About 2 hrs to fix

    Function adapter has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const adapter: FirebaseAdminAdapterTypes<T> = async (request, requestId) => {
      const { fullUrl, onSuccess, onError, onRequestStart, onResponseEnd, onResponseStart, onRequestEnd } =
        await getAdapterBindings<RealtimeDbAdapterType | FirestoreAdapterType>(request, requestId, "error", {});
      return new Promise<ResponseReturnType<any, any, FirebaseAdminAdapterTypes<T>>>((resolve) => {
        if (database instanceof Firestore) {
    Severity: Minor
    Found in packages/adapter-firebase-admin/src/adapter/adapter.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (database instanceof Firestore) {
          const {
            method = FirestoreMethods.getDocs,
            queryParams,
            data,
      Severity: Major
      Found in packages/adapter-firebase-admin/src/adapter/adapter.ts and 1 other location - About 7 hrs to fix
      packages/adapter-firebase/src/adapter/adapter.ts on lines 26..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 187.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            const { fullUrl, onSuccess, onError, onRequestStart, onResponseEnd, onResponseStart, onRequestEnd } =
        await getAdapterBindings<RealtimeDbAdapterType | FirestoreAdapterType>(request, requestId, "error", {});
      Severity: Major
      Found in packages/adapter-firebase-admin/src/adapter/adapter.ts and 1 other location - About 1 hr to fix
      packages/adapter-firebase/src/adapter/adapter.ts on lines 23..24

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status