Sign upLogin

BigKeeper/big-keeper

View on GitHub
Star
lib/big_keeper/model/library_model.rb

Summary

Maintainability
D
2 days
Test Coverage

Method spec_dependece_library has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
Open

    def spec_dependece_library(library_keywords_hash)
      if library_keywords_hash.include?(@name)
        library_keywords_hash.delete(@name)
      end
Severity: Minor
Found in lib/big_keeper/model/library_model.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

                if !(((next_char<='z'&&next_char>='a')||(next_char<='Z'&&next_char>='A')||(next_char<='9'&&next_char>='0')||next_char=='_')||((last_char<='z'&&last_char>='a')||(last_char<='Z'&&last_char>='A')||(last_char<='9'&&last_char>='0')||last_char=='_'))
                  if keyword.include?(".h") && line.include?("import") && line.include?("/"+keyword+">")
                    dependence_library_name = line[line.index("<")+1...line.index("/"+keyword+">")]
                    if dependence_library_name == library_name
                      tip = " [file]:"+File.basename(file_path)+" [line]: "+line.strip+" [keyword]: "+keyword
Severity: Critical
Found in lib/big_keeper/model/library_model.rb - About 3 hrs to fix

    Method get_all_public_file has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_all_public_file(path)
      all_header = FileOperator.find_all_header_file("#{path}/Pods/#{@name}")
      for file_path in all_header do
        @header_file_list[@header_file_list.size] = file_path
        file_name = File.basename(file_path)
    Severity: Minor
    Found in lib/big_keeper/model/library_model.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method spec_dependece_library has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def spec_dependece_library(library_keywords_hash)
      if library_keywords_hash.include?(@name)
        library_keywords_hash.delete(@name)
      end
    Severity: Major
    Found in lib/big_keeper/model/library_model.rb - About 2 hrs to fix

      Method get_all_public_file has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def get_all_public_file(path)
      all_header = FileOperator.find_all_header_file("#{path}/Pods/#{@name}")
      for file_path in all_header do
        @header_file_list[@header_file_list.size] = file_path
        file_name = File.basename(file_path)
      Severity: Minor
      Found in lib/big_keeper/model/library_model.rb - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                          if keyword.include?(".h") && line.include?("import") && line.include?("/"+keyword+">")
                    dependence_library_name = line[line.index("<")+1...line.index("/"+keyword+">")]
                    if dependence_library_name == library_name
                      tip = " [file]:"+File.basename(file_path)+" [line]: "+line.strip+" [keyword]: "+keyword
                      is_dependence = true
        Severity: Major
        Found in lib/big_keeper/model/library_model.rb - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if !(((next_char<='z'&&next_char>='a')||(next_char<='Z'&&next_char>='A')||(next_char<='9'&&next_char>='0')||next_char=='_')||((last_char<='z'&&last_char>='a')||(last_char<='Z'&&last_char>='A')||(last_char<='9'&&last_char>='0')||last_char=='_'))
          Severity: Minor
          Found in lib/big_keeper/model/library_model.rb and 1 other location - About 20 mins to fix
          lib/big_keeper/model/library_model.rb on lines 89..89

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status