Sign upLogin

BigKeeper/big-keeper

View on GitHub
Star
lib/big_keeper/service/module_service.rb

Summary

Maintainability
C
1 day
Test Coverage

Method push has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def push(path, user, module_name, home_branch_name, type, comment)
Severity: Minor
Found in lib/big_keeper/service/module_service.rb - About 45 mins to fix

    Method module_info has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def module_info(module_path, home_branch_name, user, type, module_name, version)
    Severity: Minor
    Found in lib/big_keeper/service/module_service.rb - About 45 mins to fix

      Method release_start has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def release_start(path, user, modules, module_name, version)
      Severity: Minor
      Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

        Method pull has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def pull(path, user, module_name, home_branch_name, type)
        Severity: Minor
        Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

          Method finish has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def finish(path, user, module_name, home_branch_name, type)
          Severity: Minor
          Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

            Method add has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def add(path, user, module_name, name, type)
            Severity: Minor
            Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

              Method rebase has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def rebase(path, user, module_name, home_branch_name, type)
              Severity: Minor
              Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                Method publish has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def publish(path, user, module_name, home_branch_name, type)
                Severity: Minor
                Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                  Method switch_to has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def switch_to(path, user, module_name, home_branch_name, type)
                  Severity: Minor
                  Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                    Method pre_publish has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def pre_publish(path, user, module_name, home_branch_name, type)
                    Severity: Minor
                    Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                      Method verify_module has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def verify_module(path, user, module_name, home_branch_name, type)
                      Severity: Minor
                      Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                        Method del has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def del(path, user, module_name, name, type)
                        Severity: Minor
                        Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                          Method release_finish has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def release_finish(path, user, modules, module_name, version)
                          Severity: Minor
                          Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                def release_start(path, user, modules, module_name, version)
      module_full_path = BigkeeperParser.module_full_path(path, user, module_name)

      git = GitOperator.new
      if !File.exist? module_full_path
                            Severity: Major
                            Found in lib/big_keeper/service/module_service.rb and 1 other location - About 2 hrs to fix
                            lib/big_keeper/service/module_service.rb on lines 196..219

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 79.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                def release_finish(path, user, modules, module_name, version)
      module_full_path = BigkeeperParser.module_full_path(path, user, module_name)

      git = GitOperator.new
      if !File.exist? module_full_path
                            Severity: Major
                            Found in lib/big_keeper/service/module_service.rb and 1 other location - About 2 hrs to fix
                            lib/big_keeper/service/module_service.rb on lines 170..193

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 79.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status