BigKeeper/big-keeper

View on GitHub
lib/big_keeper/util/gradle_file_operator.rb

Summary

Maintainability
D
2 days
Test Coverage

File gradle_file_operator.rb has 303 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'big_keeper/util/logger'
require 'big_keeper/util/gradle_content_generator'

module BigKeeper
  class GradleFileOperator
Severity: Minor
Found in lib/big_keeper/util/gradle_file_operator.rb - About 3 hrs to fix

    Method update_module_version_name has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_module_version_name(build_file, version_name)
          temp_file = Tempfile.new('.build.gradle.tmp')
          isModifyPom = false
          isBigkeeperScript = false
          isBigkeeperBackupScript = false
    Severity: Minor
    Found in lib/big_keeper/util/gradle_file_operator.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_module_version_name has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def update_module_version_name(build_file, version_name)
          temp_file = Tempfile.new('.build.gradle.tmp')
          isModifyPom = false
          isBigkeeperScript = false
          isBigkeeperBackupScript = false
    Severity: Minor
    Found in lib/big_keeper/util/gradle_file_operator.rb - About 1 hr to fix

      Method update_module_settings has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def update_module_settings(module_name, settings_file, depend_modules)
            module_full_path = BigkeeperParser.module_full_path(@path, @user, module_name)
            cache_path = File.expand_path("#{module_full_path}/.bigkeeper")
            big_settings_file = "#{cache_path}/bigkeeper_settings.gradle"
      
      
      Severity: Minor
      Found in lib/big_keeper/util/gradle_file_operator.rb - About 1 hr to fix

        Method update_module_build has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def update_module_build(build_file, module_name, depend_modules, version_name)
              module_full_path = BigkeeperParser.module_full_path(@path, @user, module_name)
              cache_path = File.expand_path("#{module_full_path}/.bigkeeper")
              big_build_file = "#{cache_path}/bigkeeper_build.gradle"
        
        
        Severity: Minor
        Found in lib/big_keeper/util/gradle_file_operator.rb - About 1 hr to fix

          Method update_home_settings has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def update_home_settings(settings_file, depend_modules)
                cache_path = File.expand_path("#{@path}/.bigkeeper")
                big_settings_file = "#{cache_path}/bigkeeper_settings.gradle"
          
                if depend_modules.empty? && !File.exist?(big_settings_file)
          Severity: Minor
          Found in lib/big_keeper/util/gradle_file_operator.rb - About 1 hr to fix

            Method update_home_build has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def update_home_build(build_file, depend_modules, version_name)
                  cache_path = File.expand_path("#{@path}/.bigkeeper")
                  big_build_file = "#{cache_path}/bigkeeper_build.gradle"
            
                  if depend_modules.empty? && !File.exist?(big_build_file)
            Severity: Minor
            Found in lib/big_keeper/util/gradle_file_operator.rb - About 1 hr to fix

              Method recover_bigkeeper_config_file has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def recover_bigkeeper_config_file(bigkeeper_config_file)
                    if !File.exist?(bigkeeper_config_file)
                      return
                    end
                    temp_file = Tempfile.new('.bigkeeper_config.tmp', :encoding => 'UTF-8')
              Severity: Minor
              Found in lib/big_keeper/util/gradle_file_operator.rb - About 1 hr to fix

                Method recover_bigkeeper_config_file has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    def recover_bigkeeper_config_file(bigkeeper_config_file)
                      if !File.exist?(bigkeeper_config_file)
                        return
                      end
                      temp_file = Tempfile.new('.bigkeeper_config.tmp', :encoding => 'UTF-8')
                Severity: Minor
                Found in lib/big_keeper/util/gradle_file_operator.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                      begin
                        File.open(settings_file, 'r') do |file|
                          file.each_line do |line|
                            temp_file.puts(line)
                          end
                Severity: Minor
                Found in lib/big_keeper/util/gradle_file_operator.rb and 2 other locations - About 25 mins to fix
                lib/big_keeper/util/gradle_file_operator.rb on lines 108..119
                lib/big_keeper/util/gradle_file_operator.rb on lines 205..216

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 31.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                      begin
                        File.open(build_file, 'r') do |file|
                          file.each_line do |line|
                            temp_file.puts(line)
                          end
                Severity: Minor
                Found in lib/big_keeper/util/gradle_file_operator.rb and 2 other locations - About 25 mins to fix
                lib/big_keeper/util/gradle_file_operator.rb on lines 108..119
                lib/big_keeper/util/gradle_file_operator.rb on lines 160..171

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 31.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                      begin
                        File.open(build_file, 'r') do |file|
                          file.each_line do |line|
                            temp_file.puts(line)
                          end
                Severity: Minor
                Found in lib/big_keeper/util/gradle_file_operator.rb and 2 other locations - About 25 mins to fix
                lib/big_keeper/util/gradle_file_operator.rb on lines 160..171
                lib/big_keeper/util/gradle_file_operator.rb on lines 205..216

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 31.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status