src/Weather/WeatherApi.php
Method indexActionGet
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function indexActionGet(): array
{
$request = $this->di->get("request");
$location = $request->getGet("location");
// Using ipValidation class from $di.
Function indexActionGet
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
Open
public function indexActionGet(): array
{
$request = $this->di->get("request");
$location = $request->getGet("location");
// Using ipValidation class from $di.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Usage of ELSE IF is discouraged; use ELSEIF instead Open
Open
} else if ($weatherChoice === "past") {
- Exclude checks