Bnei-Baruch/mdb

View on GitHub
api/auto_series.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method AssociateByLikutim.createCollection has 7 return statements (exceeds 4 allowed).
Open

func (a *AssociateByLikutim) createCollection(uid string) (*models.Collection, error) {
    startDate, err := a.findStartDate(uid)
    if err != nil {
        return nil, err
    }
Severity: Major
Found in api/auto_series.go - About 45 mins to fix

    Method AssociateBySources.createCollection has 6 return statements (exceeds 4 allowed).
    Open

    func (a *AssociateBySources) createCollection(uid string) (*models.Collection, error) {
        startDate, err := a.findStartDate(uid)
        if err != nil {
            return nil, err
        }
    Severity: Major
    Found in api/auto_series.go - About 40 mins to fix

      Function attachCollection has 5 return statements (exceeds 4 allowed).
      Open

      func attachCollection(tx boil.Executor, c *models.Collection, cu *models.ContentUnit, cus []int64) error {
          var prevPos int64
      
          if err := queries.Raw(fmt.Sprintf(LAST_POSITION_BY_C_SQL, c.ID)).QueryRow(tx).Scan(&prevPos); err != nil {
              return err
      Severity: Major
      Found in api/auto_series.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for sUid, _ := range a.seriesSources {
                if len(a.cusByS[sUid]) < MinCuNumberForNewLessonSeries {
                    continue
                }
                c, err := a.findPrevCollection(sUid)
        Severity: Major
        Found in api/auto_series.go and 1 other location - About 1 hr to fix
        api/auto_series.go on lines 206..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 135.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for _, lUid := range a.lUIDs {
                if len(a.cusByL[lUid]) < MinCuNumberForNewLessonSeries {
                    continue
                }
                c, err := a.findPrevCollection(lUid)
        Severity: Major
        Found in api/auto_series.go and 1 other location - About 1 hr to fix
        api/auto_series.go on lines 52..67

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 135.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status