Sign upLogin

Bnei-Baruch/mdb

View on GitHub
Star
api/hierarchy.go

Summary

Maintainability
C
1 day
Test Coverage

Function SourcesHierarchyHandler has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
Open

func SourcesHierarchyHandler(c *gin.Context) {
    var r SourcesHierarchyRequest
    if c.Bind(&r) != nil {
        return
    }
Severity: Minor
Found in api/hierarchy.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SourcesHierarchyHandler has 94 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func SourcesHierarchyHandler(c *gin.Context) {
    var r SourcesHierarchyRequest
    if c.Bind(&r) != nil {
        return
    }
Severity: Major
Found in api/hierarchy.go - About 2 hrs to fix

    Function TagsHierarchyHandler has 61 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TagsHierarchyHandler(c *gin.Context) {
    var r TagsHierarchyRequest
    if c.Bind(&r) != nil {
        return
    }
    Severity: Minor
    Found in api/hierarchy.go - About 1 hr to fix

      Function SourcesHierarchyHandler has 7 return statements (exceeds 4 allowed).
      Open

      func SourcesHierarchyHandler(c *gin.Context) {
    var r SourcesHierarchyRequest
    if c.Bind(&r) != nil {
        return
    }
      Severity: Major
      Found in api/hierarchy.go - About 45 mins to fix

        Function TagsHierarchyHandler has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
        Open

        func TagsHierarchyHandler(c *gin.Context) {
    var r TagsHierarchyRequest
    if c.Bind(&r) != nil {
        return
    }
        Severity: Minor
        Found in api/hierarchy.go - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if s.ParentID.Valid {
            p, ok := sources[s.ParentID.Int64]
            if ok {
                if p.Children == nil {
                    p.Children = make([]*SourceH, 0)
        Severity: Minor
        Found in api/hierarchy.go and 1 other location - About 45 mins to fix
        api/hierarchy.go on lines 246..258

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if t.ParentID.Valid {
            p, ok := tags[t.ParentID.Int64]
            if ok {
                if p.Children == nil {
                    p.Children = make([]*TagH, 0)
        Severity: Minor
        Found in api/hierarchy.go and 1 other location - About 45 mins to fix
        api/hierarchy.go on lines 136..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status