Sign upLogin

Bnei-Baruch/mdb

View on GitHub
Star
batch/kitei_makor.go

Summary

Maintainability
C
1 day
Test Coverage

Function doOrganizeKiteiMakor has a Cognitive Complexity of 52 (exceeds 20 allowed). Consider refactoring.
Open

func doOrganizeKiteiMakor(ktFiles []*models.File) error {
    cuByID := make(map[int64]*models.ContentUnit)
    cuMap := make(map[int64][]*models.File)
    noCU := make([]*models.File, 0)
    for i := range ktFiles {
Severity: Minor
Found in batch/kitei_makor.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function doOrganizeKiteiMakor has 88 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func doOrganizeKiteiMakor(ktFiles []*models.File) error {
    cuByID := make(map[int64]*models.ContentUnit)
    cuMap := make(map[int64][]*models.File)
    noCU := make([]*models.File, 0)
    for i := range ktFiles {
Severity: Major
Found in batch/kitei_makor.go - About 2 hrs to fix

    Function createKTCU has 53 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func createKTCU(exec boil.Executor, mainCU *models.ContentUnit, ktFiles []*models.File) (*models.ContentUnit, error) {
    log.Infof("Create KT CU for %d", mainCU.ID)

    var props map[string]interface{}
    if !mainCU.Properties.Valid {
    Severity: Minor
    Found in batch/kitei_makor.go - About 1 hr to fix

      Function createKTCU has 7 return statements (exceeds 4 allowed).
      Open

      func createKTCU(exec boil.Executor, mainCU *models.ContentUnit, ktFiles []*models.File) (*models.ContentUnit, error) {
    log.Infof("Create KT CU for %d", mainCU.ID)

    var props map[string]interface{}
    if !mainCU.Properties.Valid {
      Severity: Major
      Found in batch/kitei_makor.go - About 45 mins to fix

        Function doOrganizeKiteiMakor has 6 return statements (exceeds 4 allowed).
        Open

        func doOrganizeKiteiMakor(ktFiles []*models.File) error {
    cuByID := make(map[int64]*models.ContentUnit)
    cuMap := make(map[int64][]*models.File)
    noCU := make([]*models.File, 0)
    for i := range ktFiles {
        Severity: Major
        Found in batch/kitei_makor.go - About 40 mins to fix

          There are no issues that match your filters.

          Category
          Status