Sign upLogin

Bnei-Baruch/mdb

View on GitHub
Star
importer/conventions/conventions.go

Summary

Maintainability
C
1 day
Test Coverage

Function doConvention has 67 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func doConvention(exec boil.Executor, header map[string]int, record []string) error {
    // Get or create convention
    ctID := common.CONTENT_TYPE_REGISTRY.ByName[common.CT_CONGRESS].ID
    var convention models.Collection
    err := queries.Raw(
Severity: Minor
Found in importer/conventions/conventions.go - About 1 hr to fix

    Function doConvention has 8 return statements (exceeds 4 allowed).
    Open

    func doConvention(exec boil.Executor, header map[string]int, record []string) error {
    // Get or create convention
    ctID := common.CONTENT_TYPE_REGISTRY.ByName[common.CT_CONGRESS].ID
    var convention models.Collection
    err := queries.Raw(
    Severity: Major
    Found in importer/conventions/conventions.go - About 50 mins to fix

      Function handleConventions has 7 return statements (exceeds 4 allowed).
      Open

      func handleConventions(db *sql.DB) error {
    records, err := utils.ReadCSV(CONVENTIONS_FILE)
    if err != nil {
        return errors.Wrap(err, "Read conventions")
    }
      Severity: Major
      Found in importer/conventions/conventions.go - About 45 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func handleConventions(db *sql.DB) error {
    records, err := utils.ReadCSV(CONVENTIONS_FILE)
    if err != nil {
        return errors.Wrap(err, "Read conventions")
    }
        Severity: Major
        Found in importer/conventions/conventions.go and 2 other locations - About 3 hrs to fix
        importer/sources/sources.go on lines 67..102
        importer/tvshows/tvshows.go on lines 62..97

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 261.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func ImportConvetions() {
    var err error
    clock := time.Now()

    log.SetFormatter(&log.TextFormatter{FullTimestamp: true})
        Severity: Major
        Found in importer/conventions/conventions.go and 1 other location - About 2 hrs to fix
        importer/tvshows/tvshows.go on lines 37..60

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 225.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for _, l := range LANGS {
        n := record[header[l+".name"]]
        if n == "" {
            continue
        }
        Severity: Major
        Found in importer/conventions/conventions.go and 1 other location - About 1 hr to fix
        importer/tvshows/tvshows.go on lines 147..165

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 142.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status