Sign upLogin

Bnei-Baruch/mdb

View on GitHub
Star
importer/kabcoil/titles.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function doImportTitles has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
Open

func doImportTitles(path string) error {
    log.Infof("Processing %s", path)

    xlFile, err := excelize.OpenFile(path)
    if err != nil {
Severity: Minor
Found in importer/kabcoil/titles.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function doImportTitles has 62 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func doImportTitles(path string) error {
    log.Infof("Processing %s", path)

    xlFile, err := excelize.OpenFile(path)
    if err != nil {
Severity: Minor
Found in importer/kabcoil/titles.go - About 1 hr to fix

    Function linkToCU has 5 return statements (exceeds 4 allowed).
    Open

    func linkToCU(link string) (*models.ContentUnit, error) {
    s := strings.Split(link, "/")
    fname := s[len(s)-1]

    kmFile, err := kmodels.FileAssets(kmdb, qm.Where("name = ?", fname)).One()
    Severity: Major
    Found in importer/kabcoil/titles.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status