Sign upLogin

Bnei-Baruch/mdb

View on GitHub
Star
importer/kmedia/holidays.go

Summary

Maintainability
C
1 day
Test Coverage

Function loadAndImportMissingHolidayCollections has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

func loadAndImportMissingHolidayCollections() (map[int]*models.Collection, error) {
    hcal := new(hebcal.Hebcal)
    if err := hcal.Load(); err != nil {
        return nil, errors.Wrap(err, "Load hebcal")
    }
Severity: Minor
Found in importer/kmedia/holidays.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function importHolidaysContainers has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

func importHolidaysContainers(csMAp map[int]*models.Collection) error {
    cnMap, cuMap, err := loadContainersInCatalogsAndCUs(12)
    if err != nil {
        return errors.Wrap(err, "Load containers")
    }
Severity: Minor
Found in importer/kmedia/holidays.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function loadAndImportMissingHolidayCollections has 68 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func loadAndImportMissingHolidayCollections() (map[int]*models.Collection, error) {
    hcal := new(hebcal.Hebcal)
    if err := hcal.Load(); err != nil {
        return nil, errors.Wrap(err, "Load hebcal")
    }
Severity: Minor
Found in importer/kmedia/holidays.go - About 1 hr to fix

    Function importHolidaysContainers has 51 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func importHolidaysContainers(csMAp map[int]*models.Collection) error {
    cnMap, cuMap, err := loadContainersInCatalogsAndCUs(12)
    if err != nil {
        return errors.Wrap(err, "Load containers")
    }
    Severity: Minor
    Found in importer/kmedia/holidays.go - About 1 hr to fix

      Function loadAndImportMissingHolidayCollections has 8 return statements (exceeds 4 allowed).
      Open

      func loadAndImportMissingHolidayCollections() (map[int]*models.Collection, error) {
    hcal := new(hebcal.Hebcal)
    if err := hcal.Load(); err != nil {
        return nil, errors.Wrap(err, "Load hebcal")
    }
      Severity: Major
      Found in importer/kmedia/holidays.go - About 50 mins to fix

        Function importHolidaysContainers has 5 return statements (exceeds 4 allowed).
        Open

        func importHolidaysContainers(csMAp map[int]*models.Collection) error {
    cnMap, cuMap, err := loadContainersInCatalogsAndCUs(12)
    if err != nil {
        return errors.Wrap(err, "Load containers")
    }
        Severity: Major
        Found in importer/kmedia/holidays.go - About 35 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          func ImportHolidays() {
    clock := Init()

    stats = NewImportStatistics()
          Severity: Major
          Found in importer/kmedia/holidays.go and 2 other locations - About 45 mins to fix
          importer/kmedia/clips.go on lines 151..165
          importer/kmedia/vls.go on lines 65..79

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status