Sign upLogin

Bnei-Baruch/mdb

View on GitHub
Star
importer/roza/cu_analysis.go

Summary

Maintainability
D
2 days
Test Coverage

Function compareIdxDir has a Cognitive Complexity of 83 (exceeds 20 allowed). Consider refactoring.
Open

func compareIdxDir(
    d *IdxDirectory,
    mdbFiles map[string]*models.File,
    kmFiles map[string]*MiniKMFile,
    cudMap map[int64]int64,
Severity: Minor
Found in importer/roza/cu_analysis.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function compareIdxDir has 104 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func compareIdxDir(
    d *IdxDirectory,
    mdbFiles map[string]*models.File,
    kmFiles map[string]*MiniKMFile,
    cudMap map[int64]int64,
Severity: Major
Found in importer/roza/cu_analysis.go - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

            if len(cuIDs) == 0 {
            diff.status = ALL_IN_NO_UNIT
        } else if len(cuIDs) == 1 {
            var inCU int
            for _, v := range cuIDs {
    Severity: Major
    Found in importer/roza/cu_analysis.go - About 45 mins to fix

      Function compareIdxDir has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          d *IdxDirectory,
    mdbFiles map[string]*models.File,
    kmFiles map[string]*MiniKMFile,
    cudMap map[int64]int64,
    filesByCU map[int64]map[string]*models.File) *IdxDirDiff {
      Severity: Minor
      Found in importer/roza/cu_analysis.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func MatchUnits() {
    clock := Init()

    idx := new(RozaIndex)
    utils.Must(idx.Load(mdb))
        Severity: Major
        Found in importer/roza/cu_analysis.go and 1 other location - About 3 hrs to fix
        importer/roza/mdb_vs_roza.go on lines 34..63

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 284.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func loadMDBFiles() (map[string]*models.File, error) {
    //files, err := models.Files(mdb, qm.InnerJoin("roza_index r on files.sha1=r.sha1")).All()
    files, err := models.Files(qm.Where("sha1 is not null")).All(mdb)
    if err != nil {
        return nil, errors.Wrap(err, "Load MDB files")
        Severity: Major
        Found in importer/roza/cu_analysis.go and 1 other location - About 1 hr to fix
        importer/roza/mdb_vs_roza.go on lines 65..78

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 148.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status