Bnei-Baruch/mdb

View on GitHub
importer/tvshows/tvshows.go

Summary

Maintainability
C
1 day
Test Coverage

Function doTVShow has 59 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func doTVShow(exec boil.Executor, header map[string]int, record []string) error {
    // Get or create TV Show
    ctID := common.CONTENT_TYPE_REGISTRY.ByName[common.CT_VIDEO_PROGRAM].ID
    show, err := models.Collections(
        qm.Where("type_id = ? AND (properties->>'kmedia_id')::int = ?", ctID, record[header["kmedia_id"]])).
Severity: Minor
Found in importer/tvshows/tvshows.go - About 1 hr to fix

    Function handleTVShows has 7 return statements (exceeds 4 allowed).
    Open

    func handleTVShows(db *sql.DB) error {
        records, err := utils.ReadCSV(TV_SHOWS_FILE)
        if err != nil {
            return errors.Wrap(err, "Read tv shows")
        }
    Severity: Major
    Found in importer/tvshows/tvshows.go - About 45 mins to fix

      Function doTVShow has 6 return statements (exceeds 4 allowed).
      Open

      func doTVShow(exec boil.Executor, header map[string]int, record []string) error {
          // Get or create TV Show
          ctID := common.CONTENT_TYPE_REGISTRY.ByName[common.CT_VIDEO_PROGRAM].ID
          show, err := models.Collections(
              qm.Where("type_id = ? AND (properties->>'kmedia_id')::int = ?", ctID, record[header["kmedia_id"]])).
      Severity: Major
      Found in importer/tvshows/tvshows.go - About 40 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func handleTVShows(db *sql.DB) error {
            records, err := utils.ReadCSV(TV_SHOWS_FILE)
            if err != nil {
                return errors.Wrap(err, "Read tv shows")
            }
        Severity: Major
        Found in importer/tvshows/tvshows.go and 2 other locations - About 3 hrs to fix
        importer/conventions/conventions.go on lines 58..93
        importer/sources/sources.go on lines 67..102

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 261.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func ImportTVShows() {
            var err error
            clock := time.Now()
        
            log.SetFormatter(&log.TextFormatter{FullTimestamp: true})
        Severity: Major
        Found in importer/tvshows/tvshows.go and 1 other location - About 2 hrs to fix
        importer/conventions/conventions.go on lines 33..56

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 225.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for _, l := range LANGS {
                n := record[header[l+".name"]]
                if n == "" {
                    continue
                }
        Severity: Major
        Found in importer/tvshows/tvshows.go and 1 other location - About 1 hr to fix
        importer/conventions/conventions.go on lines 152..170

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 142.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status