Sign upLogin

BookBrainz/bookbrainz-site

View on GitHub
Star
src/server/routes/entity/publisher.ts

Summary

Maintainability
F
4 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

router.get(
    '/create', auth.isAuthenticated, auth.isAuthorized(ENTITY_EDITOR), middleware.loadIdentifierTypes,
    middleware.loadLanguages, middleware.loadPublisherTypes,
    middleware.loadRelationshipTypes,
    async (req, res) => {
Severity: Major
Found in src/server/routes/entity/publisher.ts and 1 other location - About 1 day to fix
src/server/routes/entity/edition-group.ts on lines 107..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 314.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

router.get(
    '/:bbid/edit', auth.isAuthenticated, auth.isAuthorized(ENTITY_EDITOR), middleware.loadIdentifierTypes,
    middleware.loadPublisherTypes, middleware.loadLanguages,
     middleware.loadEntityRelationships, middleware.loadRelationshipTypes,
    (req, res) => {
Severity: Major
Found in src/server/routes/entity/publisher.ts and 3 other locations - About 4 hrs to fix
src/server/routes/entity/edition-group.ts on lines 340..356
src/server/routes/entity/series.ts on lines 328..344
src/server/routes/entity/work.ts on lines 348..364

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    publisher.relationships.forEach((relationship) => (
        relationshipSection.relationships[`n${relationship.id}`] = {
            attributeSetId: relationship.attributeSetId,
            attributes: relationship.attributeSet ? relationship.attributeSet.relationshipAttributes : [],
            relationshipType: relationship.type,
Severity: Major
Found in src/server/routes/entity/publisher.ts and 4 other locations - About 4 hrs to fix
src/server/routes/entity/author.ts on lines 306..315
src/server/routes/entity/edition-group.ts on lines 293..302
src/server/routes/entity/edition.ts on lines 507..516
src/server/routes/entity/work.ts on lines 321..330

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

router.post(
    '/:bbid/delete/handler', auth.isAuthenticatedForHandler, auth.isAuthorized(ENTITY_EDITOR),
    (req, res) => {
        const {orm} = req.app.locals;
        const {PublisherHeader, PublisherRevision} = orm;
Severity: Major
Found in src/server/routes/entity/publisher.ts and 5 other locations - About 2 hrs to fix
src/server/routes/entity/author.ts on lines 226..235
src/server/routes/entity/edition-group.ts on lines 219..228
src/server/routes/entity/edition.ts on lines 394..403
src/server/routes/entity/series.ts on lines 221..230
src/server/routes/entity/work.ts on lines 245..254

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

router.get('/:bbid/delete', auth.isAuthenticated, auth.isAuthorized(ENTITY_EDITOR), (req, res, next) => {
    if (!res.locals.entity.dataId) {
        return next(new ConflictError('This entity has already been deleted'));
    }
    _setPublisherTitle(res);
Severity: Major
Found in src/server/routes/entity/publisher.ts and 5 other locations - About 2 hrs to fix
src/server/routes/entity/author.ts on lines 218..224
src/server/routes/entity/edition-group.ts on lines 211..217
src/server/routes/entity/edition.ts on lines 386..392
src/server/routes/entity/series.ts on lines 213..219
src/server/routes/entity/work.ts on lines 237..243

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

router.get('/:bbid/revisions', (req, res, next) => {
    const {PublisherRevision} = req.app.locals.orm;
    _setPublisherTitle(res);
    entityRoutes.displayRevisions(req, res, next, PublisherRevision);
});
Severity: Major
Found in src/server/routes/entity/publisher.ts and 11 other locations - About 1 hr to fix
src/server/routes/entity/author.ts on lines 237..241
src/server/routes/entity/author.ts on lines 243..247
src/server/routes/entity/edition-group.ts on lines 230..234
src/server/routes/entity/edition-group.ts on lines 236..240
src/server/routes/entity/edition.ts on lines 373..377
src/server/routes/entity/edition.ts on lines 379..383
src/server/routes/entity/publisher.ts on lines 249..253
src/server/routes/entity/series.ts on lines 232..236
src/server/routes/entity/series.ts on lines 238..242
src/server/routes/entity/work.ts on lines 256..260
src/server/routes/entity/work.ts on lines 262..266

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

router.get('/:bbid/revisions/revisions', (req, res, next) => {
    const {PublisherRevision} = req.app.locals.orm;
    _setPublisherTitle(res);
    entityRoutes.updateDisplayedRevisions(req, res, next, PublisherRevision);
});
Severity: Major
Found in src/server/routes/entity/publisher.ts and 11 other locations - About 1 hr to fix
src/server/routes/entity/author.ts on lines 237..241
src/server/routes/entity/author.ts on lines 243..247
src/server/routes/entity/edition-group.ts on lines 230..234
src/server/routes/entity/edition-group.ts on lines 236..240
src/server/routes/entity/edition.ts on lines 373..377
src/server/routes/entity/edition.ts on lines 379..383
src/server/routes/entity/publisher.ts on lines 243..247
src/server/routes/entity/series.ts on lines 232..236
src/server/routes/entity/series.ts on lines 238..242
src/server/routes/entity/work.ts on lines 256..260
src/server/routes/entity/work.ts on lines 262..266

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    const identifiers = publisher.identifierSet ?
        publisher.identifierSet.identifiers.map(({type, ...rest}) => ({
            type: type.id,
            ...rest
        })) : [];
Severity: Major
Found in src/server/routes/entity/publisher.ts and 5 other locations - About 1 hr to fix
src/server/routes/entity/author.ts on lines 277..281
src/server/routes/entity/edition-group.ts on lines 270..274
src/server/routes/entity/edition.ts on lines 451..455
src/server/routes/entity/series.ts on lines 270..274
src/server/routes/entity/work.ts on lines 295..299

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

function _setPublisherTitle(res) {
    res.locals.title = utils.createEntityPageTitle(
        res.locals.entity,
        'Publisher',
        utils.template`Publisher “${'name'}”`
Severity: Major
Found in src/server/routes/entity/publisher.ts and 5 other locations - About 1 hr to fix
src/server/routes/entity/author.ts on lines 205..211
src/server/routes/entity/edition-group.ts on lines 197..203
src/server/routes/entity/edition.ts on lines 359..365
src/server/routes/entity/series.ts on lines 199..205
src/server/routes/entity/work.ts on lines 224..230

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    const aliases = publisher.aliasSet ?
        publisher.aliasSet.aliases.map(({languageId, ...rest}) => ({
            ...rest,
            language: languageId
        })) : [];
Severity: Major
Found in src/server/routes/entity/publisher.ts and 4 other locations - About 1 hr to fix
src/server/routes/entity/author.ts on lines 252..256
src/server/routes/entity/edition-group.ts on lines 245..249
src/server/routes/entity/edition.ts on lines 408..412
src/server/routes/entity/work.ts on lines 270..274

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if (entity.publisherSection.type) {
                entity.publisherSection.type = await utils.getIdByField(PublisherType, 'label', entity.publisherSection.type);
            }
Severity: Major
Found in src/server/routes/entity/publisher.ts and 4 other locations - About 45 mins to fix
src/server/routes/entity/author.ts on lines 160..162
src/server/routes/entity/author.ts on lines 163..165
src/server/routes/entity/edition.ts on lines 295..297
src/server/routes/entity/publisher.ts on lines 153..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if (entity.publisherSection.area) {
                entity.publisherSection.area = await utils.searchOption(orm, 'area', entity.publisherSection.area);
            }
Severity: Major
Found in src/server/routes/entity/publisher.ts and 4 other locations - About 45 mins to fix
src/server/routes/entity/author.ts on lines 160..162
src/server/routes/entity/author.ts on lines 163..165
src/server/routes/entity/edition.ts on lines 295..297
src/server/routes/entity/publisher.ts on lines 147..149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status