Sign upLogin

BookStackApp/BookStack

View on GitHub
Star
app/Access/LdapService.php

Summary

Maintainability
B
6 hrs
Test Coverage

File LdapService.php has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace BookStack\Access;

use BookStack\Exceptions\JsonDebugException;
Severity: Minor
Found in app/Access/LdapService.php - About 2 hrs to fix

    Function getConnection has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function getConnection()
    {
        if ($this->ldapConnection !== null) {
            return $this->ldapConnection;
        }
    Severity: Minor
    Found in app/Access/LdapService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getConnection has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getConnection()
    {
        if ($this->ldapConnection !== null) {
            return $this->ldapConnection;
        }
    Severity: Minor
    Found in app/Access/LdapService.php - About 1 hr to fix

      Function configureTlsCaCerts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function configureTlsCaCerts(string $caCertPath): void
    {
        $errMessage = "Provided path [{$caCertPath}] for LDAP TLS CA certs could not be resolved to an existing location";
        $path = realpath($caCertPath);
        if ($path === false) {
      Severity: Minor
      Found in app/Access/LdapService.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status