Sign upLogin

BookStackApp/BookStack

View on GitHub
Star
app/Console/Commands/RefreshAvatarCommand.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function processUsers has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private function processUsers(array $users, UserAvatars $userAvatar): int
    {
        $dryRun = !$this->option('force');
        $this->info(count($users) . " user(s) found to update avatars for.");
Severity: Minor
Found in app/Console/Commands/RefreshAvatarCommand.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method processUsers has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function processUsers(array $users, UserAvatars $userAvatar): int
    {
        $dryRun = !$this->option('force');
        $this->info(count($users) . " user(s) found to update avatars for.");
Severity: Minor
Found in app/Console/Commands/RefreshAvatarCommand.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return self::FAILURE;
    Severity: Major
    Found in app/Console/Commands/RefreshAvatarCommand.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status