Sign upLogin

BookStackApp/BookStack

View on GitHub
Star
app/Entities/Controllers/BookshelfController.php

Summary

Maintainability
A
1 hr
Test Coverage

Method show has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function show(Request $request, ActivityQueries $activities, string $slug)
    {
        $shelf = $this->queries->findVisibleBySlugOrFail($slug);
        $this->checkOwnablePermission('bookshelf-view', $shelf);
Severity: Minor
Found in app/Entities/Controllers/BookshelfController.php - About 1 hr to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            protected BookshelfRepo $shelfRepo,
        protected BookshelfQueries $queries,
        protected BookQueries $bookQueries,
        protected ShelfContext $shelfContext,
        protected ReferenceFetcher $referenceFetcher,
    Severity: Minor
    Found in app/Entities/Controllers/BookshelfController.php - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status