Sign upLogin

BookStackApp/BookStack

View on GitHub
Star
app/Permissions/JointPermissionBuilder.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method createManyJointPermissions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function createManyJointPermissions(array $originalEntities, array $roles)
    {
        $entities = $this->entitiesToSimpleEntities($originalEntities);
        $jointPermissions = [];
Severity: Minor
Found in app/Permissions/JointPermissionBuilder.php - About 1 hr to fix

    Method createJointPermissionData has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function createJointPermissionData(SimpleEntityData $entity, int $roleId, MassEntityPermissionEvaluator $permissionMap, array $rolePermissionMap, bool $isAdminRole): array
    Severity: Minor
    Found in app/Permissions/JointPermissionBuilder.php - About 35 mins to fix

      Function rebuildForEntity has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function rebuildForEntity(Entity $entity)
    {
        $entities = [$entity];
        if ($entity instanceof Book) {
            $books = $this->bookFetchQuery()->where('id', '=', $entity->id)->get();
      Severity: Minor
      Found in app/Permissions/JointPermissionBuilder.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createManyJointPermissions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function createManyJointPermissions(array $originalEntities, array $roles)
    {
        $entities = $this->entitiesToSimpleEntities($originalEntities);
        $jointPermissions = [];
      Severity: Minor
      Found in app/Permissions/JointPermissionBuilder.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function buildJointPermissionsForBooks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function buildJointPermissionsForBooks(EloquentCollection $books, array $roles, bool $deleteOld = false)
    {
        $entities = clone $books;

        /** @var Book $book */
      Severity: Minor
      Found in app/Permissions/JointPermissionBuilder.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status