Sign upLogin

BookStackApp/BookStack

View on GitHub
Star
app/Search/SearchOptions.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method addOptionsFromString has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function addOptionsFromString(string $searchString): void
    {
        /** @var array<string, SearchOption[]> $terms */
        $terms = [
            'exacts'   => [],
Severity: Minor
Found in app/Search/SearchOptions.php - About 1 hr to fix

    Method fromRequest has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function fromRequest(Request $request): self
    {
        if (!$request->has('search') && !$request->has('term')) {
            return static::fromString('');
        }
    Severity: Minor
    Found in app/Search/SearchOptions.php - About 1 hr to fix

      Function fromRequest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function fromRequest(Request $request): self
    {
        if (!$request->has('search') && !$request->has('term')) {
            return static::fromString('');
        }
      Severity: Minor
      Found in app/Search/SearchOptions.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function decodeEscapes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function decodeEscapes(string $input): string
    {
        $decoded = "";
        $escaping = false;
      Severity: Minor
      Found in app/Search/SearchOptions.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getAdditionalOptionsString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getAdditionalOptionsString(): string
    {
        $options = [];

        // Handle filters without UI support
      Severity: Minor
      Found in app/Search/SearchOptions.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addOptionsFromString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function addOptionsFromString(string $searchString): void
    {
        /** @var array<string, SearchOption[]> $terms */
        $terms = [
            'exacts'   => [],
      Severity: Minor
      Found in app/Search/SearchOptions.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status