Sign upLogin

BookStackApp/BookStack

View on GitHub
Star
app/Uploads/ImageResizer.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method orientImageToOriginalExif has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function orientImageToOriginalExif(InterventionImage $image, string $originalData): void
    {
        if (!extension_loaded('exif')) {
            return;
        }
Severity: Minor
Found in app/Uploads/ImageResizer.php - About 1 hr to fix

    Function orientImageToOriginalExif has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function orientImageToOriginalExif(InterventionImage $image, string $originalData): void
    {
        if (!extension_loaded('exif')) {
            return;
        }
    Severity: Minor
    Found in app/Uploads/ImageResizer.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method resizeImageData has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string $imageData,
        ?int $width,
        ?int $height,
        bool $keepRatio,
        ?string $format = null,
    Severity: Minor
    Found in app/Uploads/ImageResizer.php - About 35 mins to fix

      Method resizeToThumbnailUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Image $image,
        ?int $width,
        ?int $height,
        bool $keepRatio = false,
        bool $shouldCreate = false
      Severity: Minor
      Found in app/Uploads/ImageResizer.php - About 35 mins to fix

        Avoid too many return statements within this method.
        Open

                return $this->storage->getPublicUrl($thumbFilePath);
        Severity: Major
        Found in app/Uploads/ImageResizer.php - About 30 mins to fix

          Function resizeToThumbnailUrl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function resizeToThumbnailUrl(
        Image $image,
        ?int $width,
        ?int $height,
        bool $keepRatio = false,
          Severity: Minor
          Found in app/Uploads/ImageResizer.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status