BookStackApp/BookStack

View on GitHub

Showing 889 of 1,485 total issues

Avoid too many return statements within this function.
Open

    return false;
Severity: Major
Found in resources/js/wysiwyg/lexical/core/LexicalUtils.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return null;
    Severity: Major
    Found in resources/js/wysiwyg/lexical/core/nodes/LexicalTextNode.ts - About 30 mins to fix

      Function parseRequest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function parseRequest(Request $request): void
          {
              $this->responseHeaders['Accept-Ranges'] = $request->isMethodSafe() ? 'bytes' : 'none';
      
              $range = $this->getRangeFromRequest($request);
      Severity: Minor
      Found in app/Http/RangeSupportedStream.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function urlToPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function urlToPath(string $url): ?string
          {
              $url = ltrim(trim($url), '/');
      
              // Handle potential relative paths
      Severity: Minor
      Found in app/Uploads/ImageStorage.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseTaskListNode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function parseTaskListNode(node) {
          // Force task list item class
          node.attr('class', 'task-list-item');
      
          // Copy checkbox status and remove checkbox within editor
      Severity: Minor
      Found in resources/js/wysiwyg-tinymce/plugins-tasklist.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function login(User $user, string $method, bool $remember = false): void
          {
              if ($this->awaitingEmailConfirmation($user) || $this->needsMfaVerification($user)) {
                  $this->setLastLoginAttemptedForUser($user, $method, $remember);
      
      
      Severity: Minor
      Found in app/Access/LoginService.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function register has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function register(editor) {
          editor.addCommand('drawio', () => {
              const selectedNode = editor.selection.getNode();
              showDrawingEditor(editor, isDrawing(selectedNode) ? selectedNode : null);
          });
      Severity: Minor
      Found in resources/js/wysiwyg-tinymce/plugin-drawio.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function render($request, Throwable $e)
          {
              if ($e instanceof FatalError && str_contains($e->getMessage(), 'bytes exhausted (tried to allocate') && $this->onOutOfMemory) {
                  $response = call_user_func($this->onOutOfMemory);
                  if ($response) {
      Severity: Minor
      Found in app/Exceptions/Handler.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function debounce has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export function debounce(func, waitMs, immediate) {
          let timeout;
          return function debouncedWrapper(...args) {
              const context = this;
              const later = function debouncedTimeout() {
      Severity: Minor
      Found in resources/js/services/util.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validateTokenStructure has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function validateTokenStructure(): void
          {
              foreach (['header', 'payload'] as $prop) {
                  if (empty($this->$prop) || !is_array($this->$prop)) {
                      throw new OidcInvalidTokenException("Could not parse out a valid {$prop} within the provided token");
      Severity: Minor
      Found in app/Access/Oidc/OidcJwtWithClaims.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function queryWithTotals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function queryWithTotals(SimpleListOptions $listOptions, string $nameFilter): Builder
          {
              $searchTerm = $listOptions->getSearch();
              $sort = $listOptions->getSort();
              if ($sort === 'name' && $nameFilter) {
      Severity: Minor
      Found in app/Activity/TagRepo.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateLayout has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          updateLayout() {
              let newLayout = 'tablet';
              if (window.innerWidth <= 1000) newLayout = 'mobile';
              if (window.innerWidth >= 1400) newLayout = 'desktop';
              if (newLayout === this.lastLayoutType) return;
      Severity: Minor
      Found in resources/js/components/tri-layout.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function configureTlsCaCerts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function configureTlsCaCerts(string $caCertPath): void
          {
              $errMessage = "Provided path [{$caCertPath}] for LDAP TLS CA certs could not be resolved to an existing location";
              $path = realpath($caCertPath);
              if ($path === false) {
      Severity: Minor
      Found in app/Access/LdapService.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function loadToLocalCache has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function loadToLocalCache(string $cacheCategory): void
          {
              $query = Setting::query();
      
              if ($cacheCategory === 'app') {
      Severity: Minor
      Found in app/Settings/SettingService.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function deleteRole has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function deleteRole(int $roleId, int $migrateRoleId = 0): void
          {
              $role = $this->getRoleById($roleId);
      
              // Prevent deleting admin role or default registration role.
      Severity: Minor
      Found in app/Permissions/PermissionsRepo.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function resizeToThumbnailUrl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function resizeToThumbnailUrl(
              Image $image,
              ?int $width,
              ?int $height,
              bool $keepRatio = false,
      Severity: Minor
      Found in app/Uploads/ImageResizer.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function buildJointPermissionsForBooks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function buildJointPermissionsForBooks(EloquentCollection $books, array $roles, bool $deleteOld = false)
          {
              $entities = clone $books;
      
              /** @var Book $book */
      Severity: Minor
      Found in app/Permissions/JointPermissionBuilder.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function saveDraft has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          async saveDraft() {
              const data = {name: this.titleElem.value.trim()};
      
              const editorContent = await this.getEditorComponent().getContent();
              Object.assign(data, editorContent);
      Severity: Minor
      Found in resources/js/components/page-editor.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateAppIcon has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function updateAppIcon(Request $request): void
          {
              $sizes = [180, 128, 64, 32];
      
              // Update icon image if set
      Severity: Minor
      Found in app/Settings/AppSettingsStore.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateDOM has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          updateDOM(prevNode: CodeBlockNode, dom: HTMLElement) {
              const code = dom.querySelector('code');
              if (!code) return false;
      
              if (prevNode.__language !== this.__language) {
      Severity: Minor
      Found in resources/js/wysiwyg/nodes/code-block.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language