Sign upLogin

BookStackApp/BookStack

View on GitHub
Star
resources/js/wysiwyg/utils/table-map.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function buildCellMap has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    protected buildCellMap(table: CustomTableNode) {
        const rowsAndCells: CustomTableCellNode[][] = [];
        const setCell = (x: number, y: number, cell: CustomTableCellNode) => {
            if (typeof rowsAndCells[y] === 'undefined') {
                rowsAndCells[y] = [];
Severity: Minor
Found in resources/js/wysiwyg/utils/table-map.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildCellMap has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected buildCellMap(table: CustomTableNode) {
        const rowsAndCells: CustomTableCellNode[][] = [];
        const setCell = (x: number, y: number, cell: CustomTableCellNode) => {
            if (typeof rowsAndCells[y] === 'undefined') {
                rowsAndCells[y] = [];
Severity: Minor
Found in resources/js/wysiwyg/utils/table-map.ts - About 1 hr to fix

    Function getRangeForCell has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public getRangeForCell(cell: CustomTableCellNode): CellRange|null {
        let range: CellRange|null = null;
        const cellKey = cell.getKey();

        for (let y = 0; y < this.rowCount; y++) {
    Severity: Minor
    Found in resources/js/wysiwyg/utils/table-map.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            while (cellFilled(x, y)) {
                            targetColIndex += 1;
                            x += 1;
                        }
    Severity: Major
    Found in resources/js/wysiwyg/utils/table-map.ts - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status