Sign upLogin

BookStackApp/BookStack

View on GitHub
Star
resources/js/wysiwyg/utils/tables.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function $forEachTableCell has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

export function $forEachTableCell(table: CustomTableNode, callback: (c: CustomTableCellNode) => void|false): void {
    outer: for (const row of table.getChildren()) {
        if (!$isCustomTableRowNode(row)) {
            continue;
        }
Severity: Minor
Found in resources/js/wysiwyg/utils/tables.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function $mergeTableCellsInSelection has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function $mergeTableCellsInSelection(selection: TableSelection): void {
    const selectionShape = selection.getShape();
    const cells = $getTableCellsFromSelection(selection);
    if (cells.length === 0) {
        return;
Severity: Minor
Found in resources/js/wysiwyg/utils/tables.ts - About 1 hr to fix

    Function $mergeTableCellsInSelection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    export function $mergeTableCellsInSelection(selection: TableSelection): void {
    const selectionShape = selection.getShape();
    const cells = $getTableCellsFromSelection(selection);
    if (cells.length === 0) {
        return;
    Severity: Minor
    Found in resources/js/wysiwyg/utils/tables.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status