Boostport/address

View on GitHub
validate.go

Summary

Maintainability
C
7 hrs
Test Coverage
B
81%

Function checkRequiredFields has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func checkRequiredFields(address Address, requiredFields map[Field]struct{}) error {

    errors := ErrMissingRequiredFields{
        country: address.Country,
    }
Severity: Minor
Found in validate.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkSubdivisions has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func checkSubdivisions(address Address, administrativeAreaData []administrativeArea) error {

    var err *multierror.Error

    if address.AdministrativeArea != "" {
Severity: Minor
Found in validate.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkPostCode has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func checkPostCode(address Address, regex postCodeRegex) error {

    var err *multierror.Error

    if address.PostCode != "" && regex.regex != "" {
Severity: Minor
Found in validate.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if !dependentLocalityRegex.MatchString(address.PostCode) {
                        err = multierror.Append(err, ErrInvalidPostCode)
                        return err.ErrorOrNil()
                    }
Severity: Major
Found in validate.go - About 45 mins to fix

    Function checkSubdivisions has 6 return statements (exceeds 4 allowed).
    Open

    func checkSubdivisions(address Address, administrativeAreaData []administrativeArea) error {
    
        var err *multierror.Error
    
        if address.AdministrativeArea != "" {
    Severity: Major
    Found in validate.go - About 40 mins to fix

      Function checkPostCode has 5 return statements (exceeds 4 allowed).
      Open

      func checkPostCode(address Address, regex postCodeRegex) error {
      
          var err *multierror.Error
      
          if address.PostCode != "" && regex.regex != "" {
      Severity: Major
      Found in validate.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status