Boostport/migration

View on GitHub

Showing 22 of 22 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (driver *Driver) Migrate(migration *m.PlannedMigration) (err error) {
    var (
        migrationStatements *parser.ParsedMigration
        insertVersion       string
    )
Severity: Major
Found in driver/postgres/postgres.go and 1 other location - About 6 hrs to fix
driver/sqlite/sqlite.go on lines 80..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 455.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (driver *Driver) Migrate(migration *m.PlannedMigration) (err error) {
    var (
        migrationStatements *parser.ParsedMigration
        insertVersion       string
    )
Severity: Major
Found in driver/sqlite/sqlite.go and 1 other location - About 6 hrs to fix
driver/postgres/postgres.go on lines 72..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 455.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func (driver *Driver) Versions() ([]string, error) {
    var versions []string

    rows, err := driver.db.Query("SELECT version FROM " + phoenixTableName + " ORDER BY version DESC")
    if err != nil {
Severity: Major
Found in driver/phoenix/phoenix.go and 3 other locations - About 1 hr to fix
driver/mysql/mysql.go on lines 112..136
driver/postgres/postgres.go on lines 125..148
driver/sqlite/sqlite.go on lines 135..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func (driver *Driver) Versions() ([]string, error) {
    var versions []string

    rows, err := driver.db.Query("SELECT version FROM " + mysqlTableName + " ORDER BY version DESC")
    if err != nil {
Severity: Major
Found in driver/mysql/mysql.go and 3 other locations - About 1 hr to fix
driver/phoenix/phoenix.go on lines 113..136
driver/postgres/postgres.go on lines 125..148
driver/sqlite/sqlite.go on lines 135..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func (driver *Driver) Versions() ([]string, error) {
    var versions []string

    rows, err := driver.db.Query("SELECT version FROM " + sqliteTableName + " ORDER BY version DESC")
    if err != nil {
Severity: Major
Found in driver/sqlite/sqlite.go and 3 other locations - About 1 hr to fix
driver/mysql/mysql.go on lines 112..136
driver/phoenix/phoenix.go on lines 113..136
driver/postgres/postgres.go on lines 125..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func (driver *Driver) Versions() ([]string, error) {
    var versions []string

    rows, err := driver.db.Query("SELECT version FROM " + postgresTableName + " ORDER BY version DESC")
    if err != nil {
Severity: Major
Found in driver/postgres/postgres.go and 3 other locations - About 1 hr to fix
driver/mysql/mysql.go on lines 112..136
driver/phoenix/phoenix.go on lines 113..136
driver/sqlite/sqlite.go on lines 135..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method Driver.Migrate has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func (driver *Driver) Migrate(migration *m.PlannedMigration) (err error) {
    var (
        migrationStatements *parser.ParsedMigration
        insertVersion       string
    )
Severity: Minor
Found in driver/sqlite/sqlite.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Driver.Migrate has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func (driver *Driver) Migrate(migration *m.PlannedMigration) (err error) {
    var (
        migrationStatements *parser.ParsedMigration
        insertVersion       string
    )
Severity: Minor
Found in driver/postgres/postgres.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func NewFromDB(db *sql.DB) (m.Driver, error) {
    if _, ok := db.Driver().(*mysql.MySQLDriver); !ok {
        return nil, errors.New("database instance is not using the MySQL driver")
    }

Severity: Major
Found in driver/mysql/mysql.go and 3 other locations - About 1 hr to fix
driver/phoenix/phoenix.go on lines 43..61
driver/postgres/postgres.go on lines 42..58
driver/sqlite/sqlite.go on lines 48..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func NewFromDB(db *sql.DB) (m.Driver, error) {
    if _, ok := db.Driver().(*stdlib.Driver); !ok {
        return nil, errors.New("database instance is not using the postgres driver")
    }
    if err := db.Ping(); err != nil {
Severity: Major
Found in driver/postgres/postgres.go and 3 other locations - About 1 hr to fix
driver/mysql/mysql.go on lines 48..64
driver/phoenix/phoenix.go on lines 43..61
driver/sqlite/sqlite.go on lines 48..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func NewFromDB(db *sql.DB) (m.Driver, error) {
    if _, ok := db.Driver().(*avatica.Driver); !ok {
        return nil, errors.New("database instance is not using the avatica driver")
    }

Severity: Major
Found in driver/phoenix/phoenix.go and 3 other locations - About 1 hr to fix
driver/mysql/mysql.go on lines 48..64
driver/postgres/postgres.go on lines 42..58
driver/sqlite/sqlite.go on lines 48..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func NewFromDB(db *sql.DB) (m.Driver, error) {
    if _, ok := db.Driver().(*sqlite.Driver); !ok {
        return nil, errors.New("database instance is not using the postgres driver")
    }

Severity: Major
Found in driver/sqlite/sqlite.go and 3 other locations - About 1 hr to fix
driver/mysql/mysql.go on lines 48..64
driver/phoenix/phoenix.go on lines 43..61
driver/postgres/postgres.go on lines 42..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func New(dsn string) (m.Driver, error) {
    db, err := sql.Open("avatica", dsn)
    if err != nil {
        return nil, err
    }
Severity: Major
Found in driver/phoenix/phoenix.go and 1 other location - About 1 hr to fix
driver/postgres/postgres.go on lines 22..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func New(dsn string) (m.Driver, error) {
    db, err := sql.Open("pgx", dsn)
    if err != nil {
        return nil, err
    }
Severity: Major
Found in driver/postgres/postgres.go and 1 other location - About 1 hr to fix
driver/phoenix/phoenix.go on lines 23..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method Driver.Migrate has 7 return statements (exceeds 4 allowed).
Open

func (driver *Driver) Migrate(migration *m.PlannedMigration) (err error) {
    var (
        migrationStatements *parser.ParsedMigration
        insertVersion       string
    )
Severity: Major
Found in driver/sqlite/sqlite.go - About 45 mins to fix

    Method Driver.Migrate has 7 return statements (exceeds 4 allowed).
    Open

    func (driver *Driver) Migrate(migration *m.PlannedMigration) (err error) {
        var (
            migrationStatements *parser.ParsedMigration
            insertVersion       string
        )
    Severity: Major
    Found in driver/postgres/postgres.go - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if migration.Direction == m.Up {
              if _, err := driver.db.Exec("INSERT INTO "+mysqlTableName+" (version) VALUES (?)", migration.ID); err != nil {
                  return err
              }
          } else {
      Severity: Minor
      Found in driver/mysql/mysql.go and 1 other location - About 40 mins to fix
      driver/phoenix/phoenix.go on lines 99..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 111.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if migration.Direction == m.Up {
              if _, err := driver.db.Exec("UPSERT INTO "+phoenixTableName+" (version) VALUES (?)", migration.ID); err != nil {
                  return err
              }
          } else {
      Severity: Minor
      Found in driver/phoenix/phoenix.go and 1 other location - About 40 mins to fix
      driver/mysql/mysql.go on lines 98..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 111.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function New has 5 return statements (exceeds 4 allowed).
      Open

      func New(dsn string) (m.Driver, error) {
          parsedDSN, err := mysql.ParseDSN(dsn)
          if err != nil {
              return nil, err
          }
      Severity: Major
      Found in driver/mysql/mysql.go - About 35 mins to fix

        Function getMigrations has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func getMigrations(migrations Source) ([]*Migration, error) {
            var m []*Migration
            tempMigrations := map[string]*Migration{}
        
            files, err := migrations.ListMigrationFiles()
        Severity: Minor
        Found in migration.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language