Sign upLogin

BrownPaperBag/duffel-auth

View on GitHub
Star

Showing 22 of 22 total issues

Function initialiseSchema has 191 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var initialiseSchema = function(database, additions) {

  /**
  * User model. Password hashing and flood control from:
  * {@link http://devsmash.com/blog/password-authentication-with-mongoose-and-bcrypt}
Severity: Major
Found in lib/models/User.js - About 7 hrs to fix

    Function exports has 101 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(parameters) {
  var app = parameters.app;

  app.get('/forgot-password', function(req, res){
    if (req.user) {
    Severity: Major
    Found in lib/controllers/forgot-password.js - About 4 hrs to fix

      Function exports has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(app) {
  var assetManager = app.get('assetManager');
  if (!assetManager) {
    return;
  }
      Severity: Major
      Found in lib/initialisers/assets.js - About 2 hrs to fix

        Function initialiseSchema has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

        var initialiseSchema = function(database, additions) {

  /**
  * User model. Password hashing and flood control from:
  * {@link http://devsmash.com/blog/password-authentication-with-mongoose-and-bcrypt}
        Severity: Minor
        Found in lib/models/User.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function exports has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function(parameters) {
  var app = parameters.app;

  app.protect.post('/users/admin/:id', 'manage-users', function(req, res, next) {
    if (req.params.id == 'create') {
        Severity: Major
        Found in lib/controllers/admin/users/post.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                status: fields.string({
        choices: {
          'Active': User.statuses.ACTIVE,
          'Inactive': User.statuses.INACTIVE,
          'Deleted': User.statuses.DELETED
          Severity: Major
          Found in lib/models/forms/user.js and 1 other location - About 1 hr to fix
          lib/models/forms/user.js on lines 88..95

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function edit has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            edit: function(loggedInUser) {

    var permissionChoices = {};
    permissions().forEach(function(permission) {
      permissionChoices[permission] = S(permission).humanize();
          Severity: Minor
          Found in lib/models/forms/user.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  status: fields.string({
        choices: {
          'Active': User.statuses.ACTIVE,
          'Inactive': User.statuses.INACTIVE,
          'Deleted': User.statuses.DELETED
            Severity: Major
            Found in lib/models/forms/user.js and 1 other location - About 1 hr to fix
            lib/models/forms/user.js on lines 35..42

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function create has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              create: function(loggedInUser) {

    var permissionChoices = {};
    permissions().forEach(function(permission) {
      permissionChoices[permission] = S(permission).humanize();
            Severity: Minor
            Found in lib/models/forms/user.js - About 1 hr to fix

              Function exports has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function(app, database, callback) {
  app.protect = protect(app);

  require('./models/User').initialise(database);
  User = require('./models/User').model();
              Severity: Minor
              Found in lib/initialise.js - About 1 hr to fix

                Function exports has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                module.exports = function(parameters) {
  var app = parameters.app;

  app.protect.post('/users/admin/create', 'manage-users', function(req, res) {
                Severity: Minor
                Found in lib/controllers/admin/users/create/post.js - About 1 hr to fix

                  Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function(parameters) {
  var app = parameters.app;

  /**
   * Process login form
                  Severity: Minor
                  Found in lib/controllers/api/login/post.js - About 1 hr to fix

                    Function getAuthenticated has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      User.getAuthenticated = function(email, password, callback) {
    this.findOne({
      where: {
        email: email
      }
                    Severity: Minor
                    Found in lib/models/User.js - About 1 hr to fix

                      Function exports has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      module.exports = function(parameters) {
  var app = parameters.app;

  /**
   * List users.
                      Severity: Minor
                      Found in lib/controllers/api/users/get.js - About 1 hr to fix

                        Function lookupPermissions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function lookupPermissions(uri, verb) {

  if (arguments.length !== 2) {
    throw new error('InvalidArgumentError')('lookupPermissions requires uri and verb');
  }
                        Severity: Minor
                        Found in lib/functions/permissions.js - About 1 hr to fix

                          Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          module.exports = function(parameters) {
  var app = parameters.app;

  app.protect.get('/users/admin', 'view-users', function(req, res){
    res.render('/duffel-auth/admin/users/index.nunjucks');
                          Severity: Minor
                          Found in lib/controllers/admin/users/get.js - About 1 hr to fix

                            Function ResetPasswordController has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function ResetPasswordController($scope, $http, $window) {
  $scope.user = {};
  $scope.submitting = false;
  $scope.formError = false;
                            Severity: Minor
                            Found in public/javascript/applications/reset-password/controllers.js - About 1 hr to fix

                              Function authenticateUser has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                function authenticateUser(email, password, done) {
    User.getAuthenticated(email, password, function(error, user, reason) {
      if (error) throw error;

      if (user) {
                              Severity: Minor
                              Found in lib/initialise.js - About 1 hr to fix

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (loggedInUser.super) {
      formFields.super = fields.boolean({
        label: 'Super User',
        cssClasses: {
          label: ['field__label--checkbox'],
                                Severity: Minor
                                Found in lib/models/forms/user.js and 1 other location - About 40 mins to fix
                                lib/models/forms/user.js on lines 98..105

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 49.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (loggedInUser.super) {
      formFields.super = fields.boolean({
        label: 'Super User',
        cssClasses: {
          label: ['field__label--checkbox'],
                                Severity: Minor
                                Found in lib/models/forms/user.js and 1 other location - About 40 mins to fix
                                lib/models/forms/user.js on lines 45..52

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 49.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language