BrownPaperBag/duffel-auth

View on GitHub

Showing 18 of 22 total issues

Function initialiseSchema has 191 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var initialiseSchema = function(database, additions) {

  /**
  * User model. Password hashing and flood control from:
  * {@link http://devsmash.com/blog/password-authentication-with-mongoose-and-bcrypt}
Severity: Major
Found in lib/models/User.js - About 7 hrs to fix

    Function exports has 101 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(parameters) {
      var app = parameters.app;
    
      app.get('/forgot-password', function(req, res){
        if (req.user) {
    Severity: Major
    Found in lib/controllers/forgot-password.js - About 4 hrs to fix

      Function exports has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(app) {
        var assetManager = app.get('assetManager');
        if (!assetManager) {
          return;
        }
      Severity: Major
      Found in lib/initialisers/assets.js - About 2 hrs to fix

        Function initialiseSchema has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

        var initialiseSchema = function(database, additions) {
        
          /**
          * User model. Password hashing and flood control from:
          * {@link http://devsmash.com/blog/password-authentication-with-mongoose-and-bcrypt}
        Severity: Minor
        Found in lib/models/User.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function exports has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function(parameters) {
          var app = parameters.app;
        
          app.protect.post('/users/admin/:id', 'manage-users', function(req, res, next) {
            if (req.params.id == 'create') {
        Severity: Major
        Found in lib/controllers/admin/users/post.js - About 2 hrs to fix

          Function edit has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            edit: function(loggedInUser) {
          
              var permissionChoices = {};
              permissions().forEach(function(permission) {
                permissionChoices[permission] = S(permission).humanize();
          Severity: Minor
          Found in lib/models/forms/user.js - About 1 hr to fix

            Function create has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              create: function(loggedInUser) {
            
                var permissionChoices = {};
                permissions().forEach(function(permission) {
                  permissionChoices[permission] = S(permission).humanize();
            Severity: Minor
            Found in lib/models/forms/user.js - About 1 hr to fix

              Function exports has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function(app, database, callback) {
                app.protect = protect(app);
              
                require('./models/User').initialise(database);
                User = require('./models/User').model();
              Severity: Minor
              Found in lib/initialise.js - About 1 hr to fix

                Function exports has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                module.exports = function(parameters) {
                  var app = parameters.app;
                
                  app.protect.post('/users/admin/create', 'manage-users', function(req, res) {
                
                
                Severity: Minor
                Found in lib/controllers/admin/users/create/post.js - About 1 hr to fix

                  Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function(parameters) {
                    var app = parameters.app;
                  
                    /**
                     * Process login form
                  Severity: Minor
                  Found in lib/controllers/api/login/post.js - About 1 hr to fix

                    Function getAuthenticated has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      User.getAuthenticated = function(email, password, callback) {
                        this.findOne({
                          where: {
                            email: email
                          }
                    Severity: Minor
                    Found in lib/models/User.js - About 1 hr to fix

                      Function exports has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      module.exports = function(parameters) {
                        var app = parameters.app;
                      
                        /**
                         * List users.
                      Severity: Minor
                      Found in lib/controllers/api/users/get.js - About 1 hr to fix

                        Function lookupPermissions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function lookupPermissions(uri, verb) {
                        
                          if (arguments.length !== 2) {
                            throw new error('InvalidArgumentError')('lookupPermissions requires uri and verb');
                          }
                        Severity: Minor
                        Found in lib/functions/permissions.js - About 1 hr to fix

                          Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          module.exports = function(parameters) {
                            var app = parameters.app;
                          
                            app.protect.get('/users/admin', 'view-users', function(req, res){
                              res.render('/duffel-auth/admin/users/index.nunjucks');
                          Severity: Minor
                          Found in lib/controllers/admin/users/get.js - About 1 hr to fix

                            Function ResetPasswordController has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function ResetPasswordController($scope, $http, $window) {
                              $scope.user = {};
                              $scope.submitting = false;
                              $scope.formError = false;
                            
                            
                            Severity: Minor
                            Found in public/javascript/applications/reset-password/controllers.js - About 1 hr to fix

                              Function authenticateUser has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                function authenticateUser(email, password, done) {
                                  User.getAuthenticated(email, password, function(error, user, reason) {
                                    if (error) throw error;
                              
                                    if (user) {
                              Severity: Minor
                              Found in lib/initialise.js - About 1 hr to fix

                                Function authenticateUser has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  function authenticateUser(email, password, done) {
                                    User.getAuthenticated(email, password, function(error, user, reason) {
                                      if (error) throw error;
                                
                                      if (user) {
                                Severity: Minor
                                Found in lib/initialise.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                module.exports = new function() {
                                  this.tags = ['permission'];
                                
                                  this.parse = function(parser, nodes) {
                                    var tok = parser.nextToken();
                                Severity: Minor
                                Found in lib/nunjucks-tags/permission.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language