Sign upLogin

BytecodeAgency/import-boundary-checker

View on GitHub
Star

Showing 2 of 2 total issues

Method RuleChecker.Check has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
Open

func (rc *RuleChecker) Check() (isValid bool) {
    for file, imports := range rc.ImportChart {
        forbiddenImports := rc.findForbiddenImportsForFilename(file)
        allowedImports := rc.findAllowedImportsForFilename(file)
        for _, importLine := range imports {
Severity: Minor
Found in rulechecker/rulechecker.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Runner.Run has 5 return statements (exceeds 4 allowed).
Open

func (r *Runner) Run() (failureOccurred bool) {
    // Lex and parse to get import ruleset
    l := r.doLex(r.configFile)
    if r.failed {
        return r.failed
Severity: Major
Found in runner/runner.go - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language