Sign upLogin

CDJ11/CDJ

View on GitHub
Star
app/controllers/admin/spending_proposals_controller.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method summary has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def summary
    @spending_proposals = SpendingProposal.group(:geozone).sum(:price).sort_by{|geozone, count| geozone.present? ? geozone.name : "z"}
    @spending_proposals_with_supports = SpendingProposal.with_supports.group(:geozone).sum(:price)
                                                        .sort_by{|geozone, count| geozone.present? ? geozone.name : "z"}
  end
Severity: Minor
Found in app/controllers/admin/spending_proposals_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line is too long. [101/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

  has_filters %w{valuation_open without_admin managed valuating valuation_finished all}, only: :index
Severity: Minor
Found in app/controllers/admin/spending_proposals_controller.rb by rubocop

Line is too long. [116/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

      params.require(:spending_proposal).permit(:title, :description, :external_url, :geozone_id, :association_name,
Severity: Minor
Found in app/controllers/admin/spending_proposals_controller.rb by rubocop

Line is too long. [134/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    @spending_proposals = SpendingProposal.group(:geozone).sum(:price).sort_by{|geozone, count| geozone.present? ? geozone.name : "z"}
Severity: Minor
Found in app/controllers/admin/spending_proposals_controller.rb by rubocop

%w-literals should be delimited by [ and ]. (https://github.com/bbatsov/ruby-style-guide#percent-literal-braces)
Open

  has_filters %w{valuation_open without_admin managed valuating valuation_finished all}, only: :index
Severity: Minor
Found in app/controllers/admin/spending_proposals_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

      redirect_to admin_spending_proposal_path(@spending_proposal, SpendingProposal.filter_params(params)),
Severity: Minor
Found in app/controllers/admin/spending_proposals_controller.rb by rubocop

Line is too long. [120/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

                                                        .sort_by{|geozone, count| geozone.present? ? geozone.name : "z"}
Severity: Minor
Found in app/controllers/admin/spending_proposals_controller.rb by rubocop

There are no issues that match your filters.

Category
Status