app/controllers/users/confirmations_controller.rb
Method update
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
Open
def update
self.resource = resource_class.find_by(confirmation_token: params[:confirmation_token])
if resource.encrypted_password.blank?
resource.assign_attributes(resource_params)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method show
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def show
# In the default implementation, this already confirms the resource:
# self.resource = self.resource = resource_class.confirm_by_token(params[:confirmation_token])
self.resource = resource_class.find_by(confirmation_token: params[:confirmation_token])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Line is too long. [109/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits) Open
Open
respond_with_navigational(resource){ redirect_to after_confirmation_path_for(resource_name, resource) }
- Exclude checks
Line is too long. [112/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits) Open
Open
# New condition added to if: when no password was given, display the "show" view (which uses "update" above)
- Exclude checks
Line is too long. [125/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits) Open
Open
resource.confirm # Last change: confirm happens here for people with passwords instead of af the top of the show action
- Exclude checks