Sign upLogin

CDJ11/CDJ

View on GitHub
Star
app/models/custom/abilities/common.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(user)
      merge Abilities::Everyone.new(user)

      can [:read, :update], User, id: user.id
Severity: Major
Found in app/models/custom/abilities/common.rb - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          if user.level_two_or_three_verified?
        can :vote, Proposal
        can :vote_featured, Proposal
        can :vote, SpendingProposal
        can :create, SpendingProposal
    Severity: Major
    Found in app/models/custom/abilities/common.rb and 1 other location - About 3 hrs to fix
    app/models/abilities/common.rb on lines 65..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    3 trailing blank lines detected. (https://github.com/bbatsov/ruby-style-guide#newline-eof)
    Open

    Severity: Minor
    Found in app/models/custom/abilities/common.rb by rubocop

    Line is too long. [120/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

            can :destroy, Budget::Investment,              budget: { phase: ["accepting", "reviewing"] }, author_id: user.id
    Severity: Minor
    Found in app/models/custom/abilities/common.rb by rubocop

    There are no issues that match your filters.

    Category
    Status