Sign upLogin

CDJ11/CDJ

View on GitHub
Star
app/models/poll/recount.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method update_logs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def update_logs
    amounts_changed = false

    [:white, :null, :total].each do |amount|
      next unless send("#{amount}_amount_changed?") && send("#{amount}_amount_was").present?
Severity: Minor
Found in app/models/poll/recount.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

%w-literals should be delimited by [ and ]. (https://github.com/bbatsov/ruby-style-guide#percent-literal-braces)
Open

  VALID_ORIGINS = %w{web booth letter}.freeze
Severity: Minor
Found in app/models/poll/recount.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

There are no issues that match your filters.

Category
Status