CDJ11/CDJ

File budget_investments_spec.rb has 270 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rails_helper'

feature 'Tags' do

  let(:author)  { create(:user, :level_two, username: 'Isabel') }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  context 'Tag cloud' do

    scenario 'Display user tags' do
      earth = create(:debate, tag_list: 'Medio Ambiente')
      money = create(:debate, tag_list: 'Economía')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  context 'Tag cloud' do

    scenario 'Display user tags' do
      earth = create(:proposal, tag_list: 'Medio Ambiente')
      money = create(:proposal, tag_list: 'Economía')

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  describe "investments_orders" do
    it "is random when accepting and reviewing" do
      budget.phase = 'accepting'
      expect(budget.investments_orders).to eq(['random'])
      budget.phase = 'reviewing'

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  describe "investments_orders" do
    it "is random when accepting and reviewing" do
      budget.phase = 'accepting'
      expect(budget.investments_orders).to eq(['random'])
      budget.phase = 'reviewing'

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "checks debate phase" do
      # future
      process.update_attributes(debate_start_date: Date.current + 2.days, debate_end_date: Date.current + 3.days)
      expect(process.debate_phase.started?).to be false

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "checks debate phase" do
      # future
      process.update_attributes(debate_start_date: Date.current + 2.days, debate_end_date: Date.current + 3.days)
      expect(process.debate_phase.open?).to be false

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "checks allegations phase" do

      # future
      process.update_attributes(allegations_start_date: Date.current + 2.days, allegations_end_date: Date.current + 3.days)
      expect(process.allegations_phase.open?).to be false

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "checks allegations phase" do
      # future
      process.update_attributes(allegations_start_date: Date.current + 2.days, allegations_end_date: Date.current + 3.days)
      expect(process.allegations_phase.started?).to be false

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "Showing the valuating checkbox" do
      investment1 = create(:budget_investment, budget: budget, visible_to_valuators: true)
      investment2 = create(:budget_investment, budget: budget, visible_to_valuators: false)

      investment1.valuators << create(:valuator)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "Showing the valuating checkbox" do
      investment1 = create(:budget_investment, budget: budget, visible_to_valuators: true)
      investment2 = create(:budget_investment, budget: budget, visible_to_valuators: false)

      investment1.valuators << create(:valuator)

• Read up
  Read up

File proposal_notifications_spec.rb has 264 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rails_helper'

feature 'Proposal Notifications' do

  xscenario "Send a notification" do

File proposal_notifications_spec.rb has 264 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rails_helper'

feature 'Proposal Notifications' do

  xscenario "Send a notification" do

Class ProposalsController has 22 methods (exceeds 20 allowed). Consider refactoring.

Open

class ProposalsController < ApplicationController
  include FeatureFlags
  include CommentableActions
  include FlagActions

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#winner_investment_authors" do
    it "returns authors of winner budget investments" do
      winner_investment = create(:budget_investment, :winner, author: user1)
      selected_investment = create(:budget_investment, :selected, author: user2)
      budget = create(:budget)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#selected_investment_authors" do
    it "returns authors of selected budget investments" do
      selected_investment = create(:budget_investment, :selected, author: user1)
      unselected_investment = create(:budget_investment, :unselected, author: user2)
      budget = create(:budget)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#current" do

    it "returns nil if there is only one budget and it is still in drafting phase" do
      budget = create(:budget, phase: "drafting")

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#current" do

    it "returns nil if there is only one budget and it is still in drafting phase" do
      budget = create(:budget, phase: "drafting")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#formatted_amount" do
    after do
      I18n.locale = :en
    end

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  context 'Debate comments' do
    let(:user)   { create(:user, email_on_comment: true) }
    let(:debate) { create(:debate, author: user) }

    scenario 'Send email on debate comment' do

• Read up
  Read up