Sign upLogin

CDJ11/CDJ

View on GitHub
Star
spec/custom/features/comments/legislation_annotations_spec.rb

Summary

Maintainability
B
5 hrs
Test Coverage

TODO found
Open

  # TODO
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by fixme

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  xscenario 'Creation date works differently in roots and in child comments, even when sorting by confidence_score' do
    old_root = create(:comment, commentable: legislation_annotation, created_at: Time.current - 10)
    new_root = create(:comment, commentable: legislation_annotation, created_at: Time.current)
    old_child = create(:comment, commentable: legislation_annotation, parent_id: new_root.id, created_at: Time.current - 10)
    new_child = create(:comment, commentable: legislation_annotation, parent_id: new_root.id, created_at: Time.current)
Severity: Major
Found in spec/custom/features/comments/legislation_annotations_spec.rb and 1 other location - About 3 hrs to fix
spec/features/comments/legislation_annotations_spec.rb on lines 108..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    scenario 'Trying to vote multiple times', :js do
      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,
                                                              @legislation_annotation.draft_version,
                                                              @legislation_annotation)
Severity: Major
Found in spec/custom/features/comments/legislation_annotations_spec.rb and 1 other location - About 1 hr to fix
spec/features/comments/legislation_annotations_spec.rb on lines 576..597

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line is too long. [124/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    old_child = create(:comment, commentable: legislation_annotation, parent_id: new_root.id, created_at: Time.current - 10)
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Line is too long. [119/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    new_child = create(:comment, commentable: legislation_annotation, parent_id: new_root.id, created_at: Time.current)
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

      @comment = create(:comment, commentable: @legislation_annotation)
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Line is too long. [118/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

  xscenario 'Creation date works differently in roots and in child comments, even when sorting by confidence_score' do
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

                                                              @legislation_annotation)
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

                                                              @legislation_annotation.draft_version,
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

      login_as(@manuela)
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

      within("#comment_#{@comment.id}_votes") do
Severity: Minor
Found in spec/custom/features/comments/legislation_annotations_spec.rb by rubocop

There are no issues that match your filters.

Category
Status