Sign upLogin

CDJ11/CDJ

View on GitHub
Star
spec/custom/features/proposal_notifications_spec.rb

Summary

Maintainability
F
4 days
Test Coverage

File proposal_notifications_spec.rb has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rails_helper'

feature 'Proposal Notifications' do

  xscenario "Send a notification" do
Severity: Minor
Found in spec/custom/features/proposal_notifications_spec.rb - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    feature 'Proposal Notifications' do

  xscenario "Send a notification" do
    author = create(:user)
    proposal = create(:proposal, author: author)
    Severity: Major
    Found in spec/custom/features/proposal_notifications_spec.rb and 1 other location - About 4 days to fix
    spec/features/proposal_notifications_spec.rb on lines 3..377

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 1092.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_link("the proposal's page", href: proposal_path(proposal, anchor: 'comments'))
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [134/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        notification1 = create(:proposal_notification, proposal: proposal, title: "Hey guys", body: "Just wanted to let you know that...")
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

          fill_in 'proposal_notification_body', with: "Please share it with others so we can make it happen!"
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [118/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_content "This message will be send to 7 people and it will be visible in the proposal's page"
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_link("the proposal's page", href: proposal_path(proposal, anchor: 'comments'))
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [111/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

                                                       body: "We are almost there please share with your peoples!")
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

          fill_in 'proposal_notification_body', with: "Please share it with others so we can make it happen!"
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        fill_in 'proposal_notification_body', with: "Please share it with others so we can make it happen!"
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [118/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_content "This message will be send to 7 people and it will be visible in the proposal's page"
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_link("the proposal's page", href: proposal_path(proposal, anchor: 'comments'))
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_link("the proposal's page", href: proposal_path(proposal, anchor: 'comments'))
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

          fill_in 'proposal_notification_body', with: "Please share it with others so we can make it happen!"
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [119/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_content "This message will be send to 14 people and it will be visible in the proposal's page"
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    Line is too long. [118/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_content "This message will be send to 1 people and it will be visible in the proposal's page"
    Severity: Minor
    Found in spec/custom/features/proposal_notifications_spec.rb by rubocop

    There are no issues that match your filters.

    Category
    Status