spec/custom/features/users_auth_spec.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File users_auth_spec.rb has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rails_helper'

feature 'Users' do

  context 'Regular authentication' do
Severity: Minor
Found in spec/custom/features/users_auth_spec.rb - About 3 hrs to fix

    TODO found
    Open

      # TODO i18n : broken because of test locale change

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      scenario 'Admin with password expired trying to use same password' do
        user = create(:user, password_changed_at: Time.current - 1.year, password: '123456789')
        admin = create(:administrator, user: user)
    
        login_as(admin.user)
    Severity: Major
    Found in spec/custom/features/users_auth_spec.rb and 1 other location - About 1 hr to fix
    spec/features/users_auth_spec.rb on lines 392..406

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      scenario 'Sign in, admin with password expired' do
        user = create(:user, password_changed_at: Time.current - 1.year)
        admin = create(:administrator, user: user)
    
        login_as(admin.user)
    Severity: Major
    Found in spec/custom/features/users_auth_spec.rb and 1 other location - About 1 hr to fix
    spec/features/users_auth_spec.rb on lines 355..370

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      scenario 'Sign in, admin without password expired' do
        user = create(:user, password_changed_at: Time.current - 360.days)
        admin = create(:administrator, user: user)
    
        login_as(admin.user)
    Severity: Minor
    Found in spec/custom/features/users_auth_spec.rb and 1 other location - About 25 mins to fix
    spec/features/users_auth_spec.rb on lines 373..380

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Line is too long. [115/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

          scenario 'Try to register with the email of an already existing user, when no email was provided by oauth' do

    Line is too long. [138/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

          let(:facebook_hash_with_email){ {provider: 'facebook', uid: '12345', info: {name: 'manuela', email: 'manuelacarmena@example.com'}} }

    Line is too long. [104/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        sent_token = /.*reset_password_token=(.*)".*/.match(ActionMailer::Base.deliveries.last.body.to_s)[1]

    Line is too long. [130/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_content "In a few minutes, you will receive an email containing instructions on resetting your password."

    Line is too long. [127/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

          scenario 'Try to register with the email of an already existing user, when an unconfirmed email was provided by oauth' do

    Line is too long. [132/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

            message = "You have been sent a message containing a verification link. Please click on this link to activate your account."

    There are no issues that match your filters.

    Category
    Status