Sign upLogin

CDJ11/CDJ

View on GitHub
Star
spec/features/admin/poll/shifts_spec.rb

Summary

Maintainability
D
2 days
Test Coverage

TODO found
Open

  # TODO i18n : broken because of test locale change
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by fixme

TODO found
Open

  # TODO i18n : broken because of test locale change
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by fixme

Identical blocks of code found in 2 locations. Consider refactoring.
Open

feature 'Admin shifts' do

  background do
    admin = create(:administrator)
    login_as(admin.user)
Severity: Major
Found in spec/features/admin/poll/shifts_spec.rb and 1 other location - About 2 days to fix
spec/custom/features/admin/poll/shifts_spec.rb on lines 3..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 697.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line is too long. [117/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    expect(page).to have_select('shift_date_recount_scrutiny_date', options: ["Select day", *recount_scrutiny_dates])
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

                                                                .map { |date| I18n.l(date, format: :long) }
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [120/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

  xscenario "Vote Collection Shift and Recount & Scrutiny Shift don't include already assigned dates to officer", :js do
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    shift1 = create(:poll_shift, :vote_collection_task, officer: officer, booth: booth, date: Date.current)
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [117/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    expect(page).to have_select('shift_date_recount_scrutiny_date', options: ["Select day", *recount_scrutiny_dates])
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [125/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

                                                                                  .map { |date| I18n.l(date, format: :long) }
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [115/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    expect(page).to have_select('shift_date_vote_collection_date', options: ["Select day", *vote_collection_dates])
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [127/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

                                                                                  .reject { |date| date == Time.zone.tomorrow }
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [112/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    vote_collection_dates = (Date.current..poll.ends_at.to_date).to_a.map { |date| I18n.l(date, format: :long) }
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [130/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    recount_scrutiny_dates = (poll.ends_at.to_date..poll.ends_at.to_date + 1.week).to_a.map { |date| I18n.l(date, format: :long) }
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

                                                                .reject { |date| date == Date.current }
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [115/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    expect(page).to have_select('shift_date_vote_collection_date', options: ["Select day", *vote_collection_dates])
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    select I18n.l(poll.ends_at.to_date + 4.days, format: :long), from: 'shift_date_recount_scrutiny_date'
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

Line is too long. [114/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    shift2 = create(:poll_shift, :recount_scrutiny_task, officer: officer, booth: booth, date: Time.zone.tomorrow)
Severity: Minor
Found in spec/features/admin/poll/shifts_spec.rb by rubocop

There are no issues that match your filters.

Category
Status