spec/features/budgets/ballots_spec.rb

Summary

Maintainability
C
1 day
Test Coverage

File ballots_spec.rb has 486 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rails_helper'

feature 'Ballots' do

  let!(:user)       { create(:user, :level_two) }
Severity: Minor
Found in spec/features/budgets/ballots_spec.rb - About 7 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        within("#sidebar") do
          expect(page).to have_content investment1.title
          expect(page).to have_content "€10,000"
    
          expect(page).to have_content investment2.title
    Severity: Minor
    Found in spec/features/budgets/ballots_spec.rb and 3 other locations - About 15 mins to fix
    spec/features/budgets/ballots_spec.rb on lines 211..216
    spec/features/budgets/ballots_spec.rb on lines 225..230
    spec/features/budgets/ballots_spec.rb on lines 421..426

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        within("#sidebar") do
          expect(page).not_to have_content investment1.title
          expect(page).not_to have_content "€10,000"
    
          expect(page).to have_content investment2.title
    Severity: Minor
    Found in spec/features/budgets/ballots_spec.rb and 3 other locations - About 15 mins to fix
    spec/features/budgets/ballots_spec.rb on lines 211..216
    spec/features/budgets/ballots_spec.rb on lines 225..230
    spec/features/budgets/ballots_spec.rb on lines 406..411

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            within("#sidebar") do
              expect(page).to have_content investment1.title
              expect(page).to have_content "€10,000"
    
              expect(page).not_to have_content investment2.title
    Severity: Minor
    Found in spec/features/budgets/ballots_spec.rb and 3 other locations - About 15 mins to fix
    spec/features/budgets/ballots_spec.rb on lines 211..216
    spec/features/budgets/ballots_spec.rb on lines 406..411
    spec/features/budgets/ballots_spec.rb on lines 421..426

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            within("#sidebar") do
              expect(page).to have_content investment2.title
              expect(page).to have_content "€20,000"
    
              expect(page).not_to have_content investment1.title
    Severity: Minor
    Found in spec/features/budgets/ballots_spec.rb and 3 other locations - About 15 mins to fix
    spec/features/budgets/ballots_spec.rb on lines 225..230
    spec/features/budgets/ballots_spec.rb on lines 406..411
    spec/features/budgets/ballots_spec.rb on lines 421..426

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Line is too long. [109/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        scenario "Do not display heading name if there is only one heading in the group (example: group city)" do

    Line is too long. [101/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

            investment1 = create(:budget_investment, :selected, heading: city_heading,      price: 10000)

    Line is too long. [101/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

            investment2 = create(:budget_investment, :selected, heading: district_heading1, price: 20000)

    Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

            district_heading2 = create(:budget_heading, group: districts, name: "District 2", price: 2000000)

    Line is too long. [113/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

          expect(page).to have_link california.name, href: budget_investments_path(budget, heading_id: california.id)

    Line is too long. [120/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

          expect(page).to have_link "You have not voted on this group yet, go vote!", href: budget_group_path(budget, group)

    Line is too long. [101/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

            investment3 = create(:budget_investment, :selected, heading: district_heading2, price: 30000)

    Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

            expect(page).to have_link "You still have €80 to invest.", href: budget_group_path(budget, group1)

    Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

            city_heading      = create(:budget_heading, group: city,      name: "All city",   price: 10000000)

    Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

            district_heading1 = create(:budget_heading, group: districts, name: "District 1", price: 1000000)

    There are no issues that match your filters.

    Category
    Status