CDJ11/CDJ

File legislation_annotations_spec.rb has 543 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rails_helper'
include ActionView::Helpers::DateHelper

feature 'Commenting legislation questions' do
  let(:user) { create :user }

TODO found

Open

    # CDJ custom : broken but no time to investigate TODO

• Exclude checks
  • Disable engine
  • Disable check

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  feature "Administrators" do
    scenario "can create comment as an administrator", :js do
      admin = create(:administrator)

      login_as(admin.user)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  feature "Moderators" do
    scenario "can create comment as a moderator", :js do
      moderator = create(:moderator)

      login_as(moderator.user)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  xscenario 'Creation date works differently in roots and in child comments, even when sorting by confidence_score' do
    old_root = create(:comment, commentable: legislation_annotation, created_at: Time.current - 10)
    new_root = create(:comment, commentable: legislation_annotation, created_at: Time.current)
    old_child = create(:comment, commentable: legislation_annotation, parent_id: new_root.id, created_at: Time.current - 10)
    new_child = create(:comment, commentable: legislation_annotation, parent_id: new_root.id, created_at: Time.current)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    xscenario 'Trying to vote multiple times', :js do
      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,
                                                              @legislation_annotation.draft_version,
                                                              @legislation_annotation)

• Read up
  Read up

Line is too long. [114/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    fill_in "comment-body-legislation_annotation_#{legislation_annotation.id}", with: 'Have you thought about...?'

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [116/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    href           = legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    c2 = create(:comment, :with_confidence_score, commentable: legislation_annotation, cached_votes_up: 10,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [119/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    new_child = create(:comment, commentable: legislation_annotation, parent_id: new_root.id, created_at: Time.current)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

                                                                       legislation_annotation.draft_version,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    c1 = create(:comment, :with_confidence_score, commentable: legislation_annotation, cached_votes_up: 100,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [118/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

  xscenario 'Creation date works differently in roots and in child comments, even when sorting by confidence_score' do

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [124/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    child_comment  = create(:comment, body: "First subcomment", commentable: legislation_annotation, parent: parent_comment)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [133/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

                     body: "<script>alert('hola')</script> <a href=\"javascript:alert('sorpresa!')\">click me<a/> http://www.url.com"

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      within("#comment_#{@comment.id}_votes") do

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      within("#comment_#{@comment.id}_votes") do

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      fill_in "comment-body-legislation_annotation_#{legislation_annotation.id}", with: "I am moderating!"

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      create(:vote, voter: @manuela, votable: @comment, vote_flag: true)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

                                                              @legislation_annotation)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [125/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

                                      ranges: [{"start" => "/p[1]", "startOffset" => 1, "end" => "/p[1]", "endOffset" => 5}])

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      fill_in "comment-body-legislation_annotation_#{legislation_annotation.id}", with: "I am your Admin!"

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

                                                  cached_votes_total: 12, created_at: Time.current - 1)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      within("#comment_#{@comment.id}_votes") do

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      within("#comment_#{@comment.id}_votes") do

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [126/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    grandchild_comment = create(:comment, body: "Last subcomment", commentable: legislation_annotation, parent: child_comment)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

                                                              @legislation_annotation.draft_version,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [110/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    fill_in "comment-body-legislation_annotation_#{legislation_annotation.id}", with: 'Testing submit button!'

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      @comment = create(:comment, commentable: @legislation_annotation)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      login_as(@manuela)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      create(:vote, voter: @pablo, votable: @comment, vote_flag: false)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [124/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    old_child = create(:comment, commentable: legislation_annotation, parent_id: new_root.id, created_at: Time.current - 10)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [104/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

                                                  cached_votes_total: 120, created_at: Time.current - 2)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    xscenario "Reply on a multiple annotation thread and display it in the single annotation thread" do

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

                                                              @legislation_annotation.draft_version,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

                                                              @legislation_annotation)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

                                                              @legislation_annotation.draft_version,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

                                                              @legislation_annotation.draft_version,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

                                                              @legislation_annotation)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [126/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

                                      ranges: [{"start" => "/p[1]", "startOffset" => 1, "end" => "/p[1]", "endOffset" => 10}])

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      create(:vote, voter: @pablo, votable: @comment, vote_flag: false)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    c3 = create(:comment, :with_confidence_score, commentable: legislation_annotation, cached_votes_up: 1,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [101/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    xscenario "Reply on a single annotation thread and display it in the merged annotation thread" do

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      create(:vote, voter: @manuela, votable: @comment, vote_flag: true)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

                                                              @legislation_annotation)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_draft_version_annotation_path(@legislation_annotation.draft_version.process,

• Exclude checks
  • Disable engine
  • Disable check