CDJ11/CDJ

File legislation_questions_spec.rb has 406 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rails_helper'
include ActionView::Helpers::DateHelper

feature 'Commenting legislation questions' do

Similar blocks of code found in 4 locations. Consider refactoring.

Open

  feature "Administrators" do
    scenario "can create comment as an administrator", :js do
      admin = create(:administrator)

      login_as(admin.user)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

  feature "Moderators" do
    scenario "can create comment as a moderator", :js do
      moderator = create(:moderator)

      login_as(moderator.user)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario 'Creation date works differently in roots and in child comments, even when sorting by confidence_score' do
    old_root = create(:comment, commentable: legislation_question, created_at: Time.current - 10)
    new_root = create(:comment, commentable: legislation_question, created_at: Time.current)
    old_child = create(:comment, commentable: legislation_question, parent_id: new_root.id, created_at: Time.current - 10)
    new_child = create(:comment, commentable: legislation_question, parent_id: new_root.id, created_at: Time.current)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario 'Comment order' do
    c1 = create(:comment, :with_confidence_score, commentable: legislation_question, cached_votes_up: 100,
                                                  cached_votes_total: 120, created_at: Time.current - 2)
    c2 = create(:comment, :with_confidence_score, commentable: legislation_question, cached_votes_up: 10,
                                                  cached_votes_total: 12, created_at: Time.current - 1)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario 'Collapsable comments', :js do
    parent_comment = create(:comment, body: "Main comment", commentable: legislation_question)
    child_comment  = create(:comment, body: "First subcomment", commentable: legislation_question, parent: parent_comment)
    grandchild_comment = create(:comment, body: "Last subcomment", commentable: legislation_question, parent: child_comment)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario 'Paginated comments' do
    per_page = 10
    (per_page + 2).times { create(:comment, commentable: legislation_question)}

    visit legislation_process_question_path(legislation_question.process, legislation_question)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    xscenario 'Trying to vote multiple times', :js do
      visit legislation_process_question_path(@legislation_question.process, @legislation_question)

      within("#comment_#{@comment.id}_votes") do
        find('.in_favor a').click

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Undoing flagging as inappropriate", :js do
    comment = create(:comment, commentable: legislation_question)
    Flag.flag(user, comment)

    login_as(user)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Flagging as inappropriate", :js do
    comment = create(:comment, commentable: legislation_question)

    login_as(user)
    visit legislation_process_question_path(legislation_question.process, legislation_question)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario 'Turns links into html links' do
    create :comment, commentable: legislation_question, body: 'Built with http://rubyonrails.org/'

    visit legislation_process_question_path(legislation_question.process, legislation_question)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario 'Sanitizes comment body for security' do
    create :comment, commentable: legislation_question,
                     body: "<script>alert('hola')</script> <a href=\"javascript:alert('sorpresa!')\">click me<a/> http://www.url.com"

    visit legislation_process_question_path(legislation_question.process, legislation_question)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  feature 'Not logged user' do
    scenario 'can not see comments forms' do
      create(:comment, commentable: legislation_question)
      visit legislation_process_question_path(legislation_question.process, legislation_question)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "N replies", :js do
    parent = create(:comment, commentable: legislation_question)

    7.times do
      create(:comment, commentable: legislation_question, parent: parent)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario 'Errors on reply', :js do
    comment = create(:comment, commentable: legislation_question, user: user)

    login_as(user)
    visit legislation_process_question_path(legislation_question.process, legislation_question)

• Read up
  Read up

Line is too long. [111/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_question_path(legislation_question.process, legislation_question, order: :oldest)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [122/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    old_child = create(:comment, commentable: legislation_question, parent_id: new_root.id, created_at: Time.current - 10)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    fill_in "comment-body-legislation_question_#{legislation_question.id}", with: 'Testing submit button!'

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [115/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_question_path(legislation_question.process, legislation_question, order: :most_voted)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      create(:vote, voter: @manuela, votable: @comment, vote_flag: true)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    c2 = create(:comment, :with_confidence_score, commentable: legislation_question, cached_votes_up: 10,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    href           = legislation_process_question_path(legislation_question.process, legislation_question)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [111/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_question_path(legislation_question.process, legislation_question, order: :newest)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [133/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

                     body: "<script>alert('hola')</script> <a href=\"javascript:alert('sorpresa!')\">click me<a/> http://www.url.com"

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [102/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      fill_in "comment-body-legislation_question_#{legislation_question.id}", with: "I am your Admin!"

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_question_path(@legislation_question.process, @legislation_question)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_question_path(@legislation_question.process, @legislation_question)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [117/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    new_child = create(:comment, commentable: legislation_question, parent_id: new_root.id, created_at: Time.current)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [110/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    process.update_attributes(debate_start_date: Date.current - 2.days, debate_end_date: Date.current - 1.day)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      create(:vote, voter: @pablo, votable: @comment, vote_flag: false)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_question_path(@legislation_question.process, @legislation_question)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      within("#comment_#{@comment.id}_votes") do

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_question_path(@legislation_question.process, @legislation_question)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_question_path(@legislation_question.process, @legislation_question)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

                                                  cached_votes_total: 12, created_at: Time.current - 1)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [115/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_question_path(legislation_question.process, legislation_question, order: :most_voted)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [124/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    grandchild_comment = create(:comment, body: "Last subcomment", commentable: legislation_question, parent: child_comment)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [111/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_question_path(legislation_question.process, legislation_question, order: :oldest)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [110/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    fill_in "comment-body-legislation_question_#{legislation_question.id}", with: 'Have you thought about...?'

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_question_path(@legislation_question.process, @legislation_question)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [104/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

                                                  cached_votes_total: 120, created_at: Time.current - 2)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [104/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    c3 = create(:comment, :with_confidence_score, commentable: legislation_question, cached_votes_up: 1,

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [111/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    visit legislation_process_question_path(legislation_question.process, legislation_question, order: :newest)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [122/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    child_comment  = create(:comment, body: "First subcomment", commentable: legislation_question, parent: parent_comment)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    c1 = create(:comment, :with_confidence_score, commentable: legislation_question, cached_votes_up: 100,

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      login_as(@manuela)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      create(:vote, voter: @pablo, votable: @comment, vote_flag: false)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      within("#comment_#{@comment.id}_votes") do

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [117/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

  scenario 'Creation date works differently in roots and in child comments, even when sorting by confidence_score' do

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [102/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      fill_in "comment-body-legislation_question_#{legislation_question.id}", with: "I am moderating!"

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      create(:vote, voter: @manuela, votable: @comment, vote_flag: true)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_question_path(@legislation_question.process, @legislation_question)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      visit legislation_process_question_path(@legislation_question.process, @legislation_question)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [112/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    legislation_question = create(:legislation_question, process: process, title: "Should we change the world?")

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      @comment = create(:comment, commentable: @legislation_question)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      within("#comment_#{@comment.id}_votes") do

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

      within("#comment_#{@comment.id}_votes") do

• Exclude checks
  • Disable engine
  • Disable check