Sign upLogin

CDJ11/CDJ

View on GitHub
Star
spec/features/comments/topics_spec.rb

Summary

Maintainability
F
2 wks
Test Coverage

File topics_spec.rb has 838 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rails_helper'
include ActionView::Helpers::DateHelper

feature 'Commenting topics from proposals' do
  let(:user)     { create :user }
Severity: Major
Found in spec/features/comments/topics_spec.rb - About 2 days to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    feature 'Commenting topics from proposals' do
  let(:user)     { create :user }
  let(:proposal) { create :proposal }

  scenario 'Index' do
    Severity: Major
    Found in spec/features/comments/topics_spec.rb and 1 other location - About 1 wk to fix
    spec/features/comments/topics_spec.rb on lines 558..1105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 1862.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    feature 'Commenting topics from budget investments' do
  let(:user)       { create :user }
  let(:investment) { create :budget_investment }

  scenario 'Index' do
    Severity: Major
    Found in spec/features/comments/topics_spec.rb and 1 other location - About 1 wk to fix
    spec/features/comments/topics_spec.rb on lines 4..551

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 1862.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_link "Go back to #{topic.title}", href: community_topic_path(community, topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          login_as(@manuela)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@proposal.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@proposal.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          within("#comment_#{@comment.id}_votes") do
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          create(:vote, voter: @pablo, votable: @comment, vote_flag: false)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

                                                      cached_votes_total: 12, created_at: Time.current - 1)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [133/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

                         body: "<script>alert('hola')</script> <a href=\"javascript:alert('sorpresa!')\">click me<a/> http://www.url.com"
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [102/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        new_child = create(:comment, commentable: topic, parent_id: new_root.id, created_at: Time.current)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        old_child = create(:comment, commentable: topic, parent_id: new_root.id, created_at: Time.current - 10)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          create(:vote, voter: @manuela, votable: @comment, vote_flag: true)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        expect(page).to have_link "Go back to #{topic.title}", href: community_topic_path(community, topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@proposal.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [109/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        grandchild_comment = create(:comment, body: "Last subcomment", commentable: topic, parent: child_comment)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

                                                      cached_votes_total: 12, created_at: Time.current - 1)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          create(:vote, voter: @pablo, votable: @comment, vote_flag: false)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          @topic = create(:topic, community: @proposal.community)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@proposal.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          @comment = create(:comment, commentable: @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          within("#comment_#{@comment.id}_votes") do
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@proposal.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          create(:vote, voter: @manuela, votable: @comment, vote_flag: true)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          login_as(@manuela)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@investment.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@investment.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [112/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

      scenario 'Creation date works differently in roots and in child comments, when sorting by confidence_score' do
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          within("#comment_#{@comment.id}_votes") do
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          @comment = create(:comment, commentable: @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@investment.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [133/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

                         body: "<script>alert('hola')</script> <a href=\"javascript:alert('sorpresa!')\">click me<a/> http://www.url.com"
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@investment.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          within("#comment_#{@comment.id}_votes") do
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        child_comment  = create(:comment, body: "First subcomment", commentable: topic, parent: parent_comment)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@proposal.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          within("#comment_#{@comment.id}_votes") do
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          create(:vote, voter: @manuela, votable: @comment, vote_flag: true)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@proposal.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          @topic = create(:topic, community: @investment.community)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@investment.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@investment.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [109/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        grandchild_comment = create(:comment, body: "Last subcomment", commentable: topic, parent: child_comment)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [104/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

                                                      cached_votes_total: 120, created_at: Time.current - 2)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          within("#comment_#{@comment.id}_votes") do
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@investment.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        child_comment  = create(:comment, body: "First subcomment", commentable: topic, parent: parent_comment)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [102/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        new_child = create(:comment, commentable: topic, parent_id: new_root.id, created_at: Time.current)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          create(:vote, voter: @manuela, votable: @comment, vote_flag: true)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          within("#comment_#{@comment.id}_votes") do
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [112/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

      scenario 'Creation date works differently in roots and in child comments, when sorting by confidence_score' do
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          create(:vote, voter: @pablo, votable: @comment, vote_flag: false)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@investment.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

        old_child = create(:comment, commentable: topic, parent_id: new_root.id, created_at: Time.current - 10)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Line is too long. [104/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
    Open

                                                      cached_votes_total: 120, created_at: Time.current - 2)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          visit community_topic_path(@proposal.community, @topic)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          within("#comment_#{@comment.id}_votes") do
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
    Open

          create(:vote, voter: @pablo, votable: @comment, vote_flag: false)
    Severity: Minor
    Found in spec/features/comments/topics_spec.rb by rubocop

    There are no issues that match your filters.

    Category
    Status