CDJ11/CDJ

File debates_spec.rb has 874 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rails_helper'

feature 'Debates' do

  before do

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      context "Search by author type" do

        xscenario "Public employee", :js do
          ana = create :user, official_level: 1
          john = create :user, official_level: 2

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context 'Recommendations' do

      let!(:best_debate)   { create(:debate, title: 'Best',   cached_votes_total: 10, tag_list: 'Sport') }
      let!(:medium_debate) { create(:debate, title: 'Medium', cached_votes_total: 5,  tag_list: 'Sport') }
      let!(:worst_debate)  { create(:debate, title: 'Worst',  cached_votes_total: 1,  tag_list: 'Sport') }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  context "Filter" do

    context "By geozone" do

      background do

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "Reorder by recommendations results maintaing search" do
      Setting['feature.user.recommendations'] = true
      Setting['feature.user.recommendations_on_debates'] = true

      user = create(:user, recommended_debates: true)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "Reorder results maintaing search", :js do
      debate1 = create(:debate, title: "Show you got",      cached_votes_up: 10,  created_at: 1.week.ago)
      debate2 = create(:debate, title: "Show what you got", cached_votes_up: 1,   created_at: 1.month.ago)
      debate3 = create(:debate, title: "Show you got",      cached_votes_up: 100, created_at: Time.current)
      debate4 = create(:debate, title: "Do not display",    cached_votes_up: 1,   created_at: 1.week.ago)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "Order by relevance by default", :js do
      debate1 = create(:debate, title: "Show you got",      cached_votes_up: 10)
      debate2 = create(:debate, title: "Show what you got", cached_votes_up: 1)
      debate3 = create(:debate, title: "Show you got",      cached_votes_up: 100)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

          scenario "Last week", :js do
            debate1 = create(:debate, created_at: 1.day.ago)
            debate2 = create(:debate, created_at: 5.days.ago)
            debate3 = create(:debate, created_at: 8.days.ago)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

          scenario "Last month", :js do
            debate1 = create(:debate, created_at: 10.days.ago)
            debate2 = create(:debate, created_at: 20.days.ago)
            debate3 = create(:debate, created_at: 33.days.ago)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

          scenario "Last year", :js do
            debate1 = create(:debate, created_at: 300.days.ago)
            debate2 = create(:debate, created_at: 350.days.ago)
            debate3 = create(:debate, created_at: 370.days.ago)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

          scenario "Last day", :js do
            debate1 = create(:debate, created_at: 1.minute.ago)
            debate2 = create(:debate, created_at: 1.hour.ago)
            debate3 = create(:debate, created_at: 2.days.ago)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      scenario 'Search by text' do
        debate1 = create(:debate, title: "Get Schwifty")
        debate2 = create(:debate, title: "Schwifty Hello")
        debate3 = create(:debate, title: "Do not show me")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      scenario "Search by text", :js do
        debate1 = create(:debate, title: "Get Schwifty")
        debate2 = create(:debate, title: "Schwifty Hello")
        debate3 = create(:debate, title: "Do not show me")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Unflagging", :js do
    user = create(:user)
    debate = create(:debate)
    Flag.flag(user, debate)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Flagging", :js do
    user = create(:user)
    debate = create(:debate)

    login_as(user)

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

          within "#js-advanced-search" do
            expect(page).to have_select('advanced_search[date_min]', selected: 'Customized')
            expect(page).to have_selector("input[name='advanced_search[date_min]'][value*='#{7.days.ago.strftime('%d/%m/%Y')}']")
            expect(page).to have_selector("input[name='advanced_search[date_max]'][value*='#{1.day.ago.strftime('%d/%m/%Y')}']")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario 'After a search do not show featured debates' do
      featured_debates = create_featured_debates
      debate = create(:debate, title: "Abcdefghi")

      visit debates_path

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    debates.each do |debate|
      within('#debates') do
        expect(page).to have_content debate.title
        expect(page).to have_content debate.description
        expect(page).to have_css("a[href='#{debate_path(debate)}']", text: debate.title)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario 'Update should not be posible if logged user is not the author' do
    debate = create(:debate)
    expect(debate).to be_editable
    login_as(create(:user))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario 'When path does not match the friendly url' do
      debate = create(:debate)

      right_path = debate_path(debate)
      old_path = "#{debates_path}/#{debate.id}-something-else"

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

          within "#js-advanced-search" do
            expect(page).to have_selector("input[name='search'][value='Schwifty']")
            expect(page).to have_select('advanced_search[official_level]', selected: Setting['official_level_1_name'])
            expect(page).to have_select('advanced_search[date_min]', selected: 'Last 24 hours')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario 'Conflictive' do
    good_debate = create(:debate)
    conflictive_debate = create(:debate, :conflictive)

    visit debate_path(conflictive_debate)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario 'Errors on update' do
    debate = create(:debate)
    login_as(debate.author)

    visit edit_debate_path(debate)

• Read up
  Read up

Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate1 = create(:debate, title: "Show you got",      cached_votes_total: 10,  tag_list: "Sport")

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [131/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    js_injection_string = "<script>alert('hey')</script> <a href=\"javascript:alert('surprise!')\">click me<a/> http://example.org"

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

        visit debate_path(@debate1)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

          expect(page).to have_content(@debate1.title)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

          expect(page).to have_content(@debate2.title)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

          expect(page).not_to have_content(@debate3.title)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [136/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate7 = create(:debate, title: "This has seven votes, and is not suggest", description: 'This is the seven', cached_votes_up: 7)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

          expect(page).to have_content(@debate1.title)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      let!(:worst_debate)  { create(:debate, title: 'Worst',  cached_votes_total: 1,  tag_list: 'Sport') }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate3 = create(:debate, title: "Show you got",      cached_votes_up: 100, created_at: Time.current)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [114/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate3 = create(:debate, title: "Do not display with same tag", cached_votes_total: 100, tag_list: "Sport")

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [102/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    expect(page).not_to have_content "This debate has been flagged as inappropriate by several users."

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

          expect(page).to have_content(@debate2.title)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [101/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

        expect(page).to have_content('Recommendations for debates are now disabled for this account')

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [128/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate6 = create(:debate, title: "Sixth debate has 6 votes", description: 'This is the sixth debate',  cached_votes_up: 6)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

          expect(page).to have_content(@debate2.title)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

          expect(page).not_to have_content(@debate3.title)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

    expect(page).to have_content "You do not have permission to carry out the action 'edit' on debate."

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [103/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate2 = create(:debate, title: "Show what you got", cached_votes_total: 1,   tag_list: "Sport")

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [129/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

            expect(page).to have_selector("input[name='advanced_search[date_min]'][value*='#{7.days.ago.strftime('%d/%m/%Y')}']")

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate1 = create(:debate, title: "Show you got",      cached_votes_up: 10,  created_at: 1.week.ago)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate2 = create(:debate, title: "Show what you got", cached_votes_up: 1,   created_at: 1.month.ago)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      let!(:best_debate)   { create(:debate, title: 'Best',   cached_votes_total: 10, tag_list: 'Sport') }

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

        @debate3 = create(:debate, geozone: @new_york)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [128/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

            expect(page).to have_selector("input[name='advanced_search[date_max]'][value*='#{1.day.ago.strftime('%d/%m/%Y')}']")

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

        @debate1 = create(:debate, geozone: @california)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [106/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      let!(:medium_debate) { create(:debate, title: 'Medium', cached_votes_total: 5,  tag_list: 'Sport') }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [118/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

            expect(page).to have_select('advanced_search[official_level]', selected: Setting['official_level_1_name'])

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate4 = create(:debate, title: "Do not display",    cached_votes_up: 1,   created_at: 1.week.ago)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

          expect(page).not_to have_content(@debate3.title)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

          expect(page).to have_content(@debate1.title)

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [124/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

Open

      debate4 = create(:debate, title: "This one has 4 votes", description: "This is the fourth debate", cached_votes_up: 4)

• Exclude checks
  • Disable engine
  • Disable check

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)

Open

        @debate2 = create(:debate, geozone: @california)

• Exclude checks
  • Disable engine
  • Disable check

Prefer not_to over to_not. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot)

Open

        expect(page).to_not have_content debate.description

• Exclude checks
  • Disable engine
  • Disable check