Sign upLogin

CDJ11/CDJ

View on GitHub
Star
spec/features/moderation/comments_spec.rb

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  feature '/moderation/ screen' do

    background do
      moderator = create(:moderator)
      login_as(moderator.user)
Severity: Major
Found in spec/features/moderation/comments_spec.rb and 2 other locations - About 2 days to fix
spec/features/moderation/debates_spec.rb on lines 49..200
spec/features/moderation/proposals_spec.rb on lines 48..199

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 507.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line is too long. [126/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

      flagged_new_comment = create(:comment, body: "Flagged new comment", created_at: Time.current - 12.hours, flags_count: 3)
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(@comment.user).to be_hidden
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Line is too long. [101/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

    create(:comment, commentable: proposal, body: "This is SPAM comment on proposal", flags_count: 2)
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(page).not_to have_css("comment_#{@comment.id}")
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(@comment.user).not_to be_hidden
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(page).not_to have_css("comment_#{@comment.id}")
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(@comment.reload).to be_ignored_flag
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(@comment.reload).not_to be_hidden
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(@comment.reload).to be_hidden
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

            check "comment_#{@comment.id}_check"
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(page).not_to have_css("comment_#{@comment.id}")
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          within("#comment_#{@comment.id}") do
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(page).not_to have_css("comment_#{@comment.id}")
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(@comment.user).not_to be_hidden
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Line is too long. [115/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

      flagged_comment = create(:comment, body: "Flagged comment", created_at: Time.current - 1.day, flags_count: 5)
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

Use let instead of an instance variable. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable)
Open

          expect(@comment.reload).to be_hidden
Severity: Minor
Found in spec/features/moderation/comments_spec.rb by rubocop

There are no issues that match your filters.

Category
Status