Sign upLogin

CDJ11/CDJ

View on GitHub
Star
spec/features/valuation_spec.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    scenario 'Access as manager is not authorized' do
      create(:manager, user: user)
      login_as(user)
      visit root_path
Severity: Major
Found in spec/features/valuation_spec.rb and 12 other locations - About 35 mins to fix
spec/custom/features/communication_spec.rb on lines 26..37
spec/custom/features/communication_spec.rb on lines 40..51
spec/custom/features/communication_spec.rb on lines 54..65
spec/custom/features/communication_spec.rb on lines 68..79
spec/features/moderation_spec.rb on lines 18..29
spec/features/moderation_spec.rb on lines 32..43
spec/features/moderation_spec.rb on lines 46..57
spec/features/officing_spec.rb on lines 19..29
spec/features/officing_spec.rb on lines 32..42
spec/features/officing_spec.rb on lines 45..55
spec/features/valuation_spec.rb on lines 19..29
spec/features/valuation_spec.rb on lines 45..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    scenario 'Access as poll officer is not authorized' do
      create(:poll_officer, user: user)
      login_as(user)
      visit root_path
Severity: Major
Found in spec/features/valuation_spec.rb and 12 other locations - About 35 mins to fix
spec/custom/features/communication_spec.rb on lines 26..37
spec/custom/features/communication_spec.rb on lines 40..51
spec/custom/features/communication_spec.rb on lines 54..65
spec/custom/features/communication_spec.rb on lines 68..79
spec/features/moderation_spec.rb on lines 18..29
spec/features/moderation_spec.rb on lines 32..43
spec/features/moderation_spec.rb on lines 46..57
spec/features/officing_spec.rb on lines 19..29
spec/features/officing_spec.rb on lines 32..42
spec/features/officing_spec.rb on lines 45..55
spec/features/valuation_spec.rb on lines 19..29
spec/features/valuation_spec.rb on lines 32..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    scenario 'Access as moderator is not authorized' do
      create(:moderator, user: user)
      login_as(user)
      visit root_path
Severity: Major
Found in spec/features/valuation_spec.rb and 12 other locations - About 35 mins to fix
spec/custom/features/communication_spec.rb on lines 26..37
spec/custom/features/communication_spec.rb on lines 40..51
spec/custom/features/communication_spec.rb on lines 54..65
spec/custom/features/communication_spec.rb on lines 68..79
spec/features/moderation_spec.rb on lines 18..29
spec/features/moderation_spec.rb on lines 32..43
spec/features/moderation_spec.rb on lines 46..57
spec/features/officing_spec.rb on lines 19..29
spec/features/officing_spec.rb on lines 32..42
spec/features/officing_spec.rb on lines 45..55
spec/features/valuation_spec.rb on lines 32..42
spec/features/valuation_spec.rb on lines 45..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    xscenario 'Access as an administrator is authorized' do
      create(:administrator, user: user)
      create(:budget)

      login_as(user)
Severity: Minor
Found in spec/features/valuation_spec.rb and 2 other locations - About 30 mins to fix
spec/features/officing_spec.rb on lines 86..96
spec/features/valuation_spec.rb on lines 58..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    xscenario 'Access as a valuator is authorized' do
      create(:valuator, user: user)
      create(:budget)

      login_as(user)
Severity: Minor
Found in spec/features/valuation_spec.rb and 2 other locations - About 30 mins to fix
spec/features/officing_spec.rb on lines 86..96
spec/features/valuation_spec.rb on lines 72..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    scenario 'Access as regular user is not authorized' do
      login_as(user)
      visit root_path

      expect(page).not_to have_link("Valuation")
Severity: Minor
Found in spec/features/valuation_spec.rb and 3 other locations - About 25 mins to fix
spec/custom/features/communication_spec.rb on lines 14..23
spec/features/moderation_spec.rb on lines 6..15
spec/features/officing_spec.rb on lines 7..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status