Sign upLogin

CDJ11/CDJ

View on GitHub
Star
spec/models/budget/phase_spec.rb

Summary

Maintainability
B
5 hrs
Test Coverage

TODO found
Open

      # TODO i18n : broken because of test locale change
Severity: Minor
Found in spec/models/budget/phase_spec.rb by fixme

TODO found
Open

      # TODO i18n : broken because of test locale change
Severity: Minor
Found in spec/models/budget/phase_spec.rb by fixme

TODO found
Open

      # TODO i18n : broken because of test locale change
Severity: Minor
Found in spec/models/budget/phase_spec.rb by fixme

TODO found
Open

      # TODO i18n : broken because of test locale change
Severity: Minor
Found in spec/models/budget/phase_spec.rb by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    describe "#prev_phase_dates_valid?" do
      let(:error) do
        "Start date must be later than the start date of the previous enabled phase"\
        " (Draft (Not visible to the public))"
      end
Severity: Major
Found in spec/models/budget/phase_spec.rb and 1 other location - About 2 hrs to fix
spec/models/budget/phase_spec.rb on lines 93..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    describe "#next_phase_dates_valid?" do
      let(:error) do
        "End date must be earlier than the end date of the next enabled phase (Accepting projects)"
      end
      # TODO i18n : broken because of test locale change
Severity: Major
Found in spec/models/budget/phase_spec.rb and 1 other location - About 2 hrs to fix
spec/models/budget/phase_spec.rb on lines 60..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line is too long. [113/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

        first_phase.update_attributes(description: '<p><a href="/"><b>a</b></a></p> <script>javascript</script>')
Severity: Minor
Found in spec/models/budget/phase_spec.rb by rubocop

There are no issues that match your filters.

Category
Status